Uh oh!
There was an error while loading. Please reload this page.
Conversation
javier-godoy
requested changes
Jan 2, 2023
Member
There was a problem hiding this comment.
1a3fe60 not only rewrites the imports to use frontend/generated instead of @vaadin/flow-frontend but also updates the dependencies with Vaadin & Hilla.
It's not clear if such a change means that we are dropping support for Vaadin 23.2 (it seems it doesn't):
- If support for Vaadin 23.2 is dropped, the commit should be labelled as a breaking change, and the PR should target a new major version (6.0.0).
- If support for Vaadin 23.2 is not dropped, then updating the dependencies and rewriting the imports should be two separate commits.
mlopezFC
commented
Mar 14, 2023
MemberAuthor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.