Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 4
New demo#133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
New demo #133
Changes from all commits
68c6dcfdb2acfdc4d9c6fca11bf6c2db2504eceea6732cade0edc6a9051ed013456c4b89b8d7bFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| package com.flowingcode.vaadin.addons.applayout; | ||
| import com.flowingcode.vaadin.addons.demo.DemoSource; | ||
| import com.vaadin.flow.component.html.Div; | ||
| import com.vaadin.flow.component.html.IFrame; | ||
| import com.vaadin.flow.router.PageTitle; | ||
| import com.vaadin.flow.router.Route; | ||
| @DemoSource("/src/test/java/com/flowingcode/addons/applayout/ApplayoutDemoView.java") | ||
| @DemoSource("/frontend/styles/app-layout/demo-styles.css") | ||
Comment on lines
+9
to
+10
Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Codebase verification Update DemoSource paths to match actual file locations The DemoSource annotation paths need to be corrected to match the actual file locations in the codebase:
🔗 Analysis chainVerify DemoSource paths The DemoSource annotation path 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash# Verify the existence of the referenced files
fd -t f "ApplayoutDemoView.java" -x echo"Found demo view: {}"
fd -t f "demo-styles.css" -p "frontend/styles/app-layout" -x echo"Found CSS: {}"Length of output: 345 Script: #!/bin/bash# Let's verify the actual content and location of the demo view file
cat ./src/test/java/com/flowingcode/addons/applayout/ApplayoutDemoView.java
# Let's search for any demo-styles.css file in the repository
fd -t f "demo-styles.css" -x echo"Found CSS: {}"# Let's also check the package declaration in the demo view
grep -n "package" ./src/test/java/com/flowingcode/addons/applayout/ApplayoutDemoView.java
Length of output: 13091 | ||
| @PageTitle("AppLayout Full Demo") | ||
| @SuppressWarnings("serial") | ||
| @Route(value = "applayout/applayout-demo", layout = AppLayoutDemoView.class) | ||
| public class AppLayoutDemo extends Div { | ||
| public AppLayoutDemo() { | ||
| setClassName("wrap-iframe"); | ||
| IFrame iframe = new IFrame("/applayout-full"); | ||
| iframe.setClassName("frame"); | ||
| iframe.setSizeFull(); | ||
| iframe.getElement().setAttribute("frameBorder", "0"); | ||
| add(iframe); | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| /*- | ||
| * #%L | ||
| * Template Add-on | ||
| * %% | ||
| * Copyright (C) 2023 Flowing Code | ||
| * %% | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * #L% | ||
| */ | ||
| package com.flowingcode.vaadin.addons.applayout; | ||
| import com.flowingcode.vaadin.addons.DemoLayout; | ||
| import com.flowingcode.vaadin.addons.GithubLink; | ||
| import com.flowingcode.vaadin.addons.demo.TabbedDemo; | ||
| import com.vaadin.flow.router.ParentLayout; | ||
| import com.vaadin.flow.router.Route; | ||
| @SuppressWarnings("serial") | ||
| @ParentLayout(DemoLayout.class) | ||
| @Route("applayout") | ||
| @GithubLink("https://github.com/FlowingCode/AppLayoutAddon") | ||
| public class AppLayoutDemoView extends TabbedDemo { | ||
| public AppLayoutDemoView() { | ||
| addDemo(AppLayoutDemo.class); | ||
| addDemo(ExtendingAppLayoutDemo.class); | ||
| setSizeFull(); | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -17,7 +17,7 @@ | ||
| * limitations under the License. | ||
| * #L% | ||
| */ | ||
| package com.flowingcode.addons.applayout; | ||
| package com.flowingcode.vaadin.addons.applayout; | ||
Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Codebase verification Package restructuring needs attention - multiple files still using old package The verification reveals that multiple source files are still using the old package structure Key files requiring package updates:
🔗 Analysis chainVerify package restructuring impact The package has been moved from 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash# Search for any remaining references to the old package
rg "com\.flowingcode\.addons\.applayout" --type java
Length of output: 4073 | ||
| import com.vaadin.flow.component.orderedlayout.VerticalLayout; | ||
| import com.vaadin.flow.router.BeforeEnterEvent; | ||
| @@ -30,6 +30,6 @@ public class DemoView extends VerticalLayout implements BeforeEnterObserver { | ||
| @Override | ||
| public void beforeEnter(BeforeEnterEvent event) { | ||
| event.forwardTo(ApplayoutDemoView.class); | ||
| event.forwardTo(AppLayoutDemoView.class); | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,24 @@ | ||||||||||
| package com.flowingcode.vaadin.addons.applayout; | ||||||||||
| import com.flowingcode.vaadin.addons.demo.DemoSource; | ||||||||||
| import com.vaadin.flow.component.html.Div; | ||||||||||
| import com.vaadin.flow.component.html.IFrame; | ||||||||||
| import com.vaadin.flow.router.PageTitle; | ||||||||||
| import com.vaadin.flow.router.Route; | ||||||||||
| @DemoSource("/src/test/java/com/flowingcode/addons/applayout/CustomAppLayout.java") | ||||||||||
| @DemoSource("/src/test/java/com/flowingcode/addons/applayout/SampleView.java") | ||||||||||
Comment on lines
+9
to
+10
Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix inconsistent package paths in @demosource annotations The package paths in the @demosource annotations don't match the actual package structure. They should be updated to include "vaadin": -@DemoSource("/src/test/java/com/flowingcode/addons/applayout/CustomAppLayout.java")-@DemoSource("/src/test/java/com/flowingcode/addons/applayout/SampleView.java")+@DemoSource("/src/test/java/com/flowingcode/vaadin/addons/applayout/CustomAppLayout.java")+@DemoSource("/src/test/java/com/flowingcode/vaadin/addons/applayout/SampleView.java")📝 Committable suggestion
Suggested change
| ||||||||||
| @PageTitle("Extending AppLayout Demo") | ||||||||||
| @SuppressWarnings("serial") | ||||||||||
| @Route(value = "applayout/extending-applayout-demo", layout = AppLayoutDemoView.class) | ||||||||||
| public class ExtendingAppLayoutDemo extends Div { | ||||||||||
| public ExtendingAppLayoutDemo() { | ||||||||||
| setClassName("wrap-iframe"); | ||||||||||
| IFrame iframe = new IFrame("/view"); | ||||||||||
| iframe.setClassName("frame"); | ||||||||||
| iframe.setSizeFull(); | ||||||||||
| iframe.getElement().setAttribute("frameBorder", "0"); | ||||||||||
| add(iframe); | ||||||||||
| } | ||||||||||
| } | ||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Warning: Multiple commons-demo dependencies found with different scopes
The verification revealed that there are two declarations of the commons-demo dependency in pom.xml:
This could lead to potential conflicts or unintended usage in production code. The dependency should be declared only once with a consistent scope.
🔗 Analysis chain
LGTM: Test scope is appropriate
The commons-demo dependency is correctly scoped as 'test' in the dependencies section.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 59
Script:
Length of output: 828