Skip to content

refactor: initialize ErrorWindow on attach - #46

Merged
paodb merged 1 commit into
masterfrom
refactor-errorWindow-init
Oct 31, 2022
Merged

refactor: initialize ErrorWindow on attach#46
paodb merged 1 commit into
masterfrom
refactor-errorWindow-init

Conversation

@javier-godoy

@javier-godoyjavier-godoy commented Oct 19, 2022

Copy link
Copy Markdown
Member

Also initialize it the first time that getChildren is called (even if it isn't attached) in order to allow reusing the dialog contents in
ErrorView:

newErrorWindow(parameter.getCaughtException(), i18n) {
@Override
publicvoidclose() {
UI.getCurrent().getPage().getHistory().back();
}
}.getChildren().forEach(this::add);

Close#44

Also initialize it the first time that getChildren is called (even if it isn't attached) in order to allow reusing the dialog contents in ErrorView.
Close#44
@paodb
paodb merged commit 376370e into masterOct 31, 2022
@paodb
paodb deleted the refactor-errorWindow-init branch October 31, 2022 11:33
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ErrorWindow constructor should not call overridable methods

2 participants

@javier-godoy@paodb