Skip to content

fix: fix compatibility with Vaadin 24.0.0.alpha6#55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paodb merged 4 commits into from
Jan 5, 2023
Merged

fix: fix compatibility with Vaadin 24.0.0.alpha6 #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d15e3b3
ci: add Vaadin 24 profile
javier-godoy Jan 4, 2023
513751c
build(demo): update commons-demo version to 3.5.1
javier-godoy Jan 4, 2023
88a9811
chore: update .gitignore
javier-godoy Jan 4, 2023
25fe617
fix: fix compatibility with Vaadin 24.0.0.alpha6
javier-godoy Jan 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 16 additions & 29 deletions .gitignore
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,18 @@
target/
!.mvn/wrapper/maven-wrapper.jar

### STS ###
.apt_generated
.classpath
.factorypath
.project
node_modules
target
.vscode
.settings
.springBeans

### IntelliJ IDEA ###
.project
.classpath
webpack.generated.js
package-lock.json
package.json
webpack.config.js
/error-screenshots
drivers
tsconfig.json
.idea
*.iws
*.iml
*.ipr

### NetBeans ###
nbproject/private/
build/
nbbuild/
dist/
nbdist/
.nb-gradle/

widgetsets
/node_modules
/webpack.generated.js
/package.json
/package-lock.json
/webpack.config.js
types.d.ts
/frontend/generated
/frontend/index.html
vite.generated.ts
25 changes: 24 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -122,7 +122,7 @@
<dependency>
<groupId>com.flowingcode.vaadin.addons.demo</groupId>
<artifactId>commons-demo</artifactId>
<version>3.5.0</version>
<version>3.5.1</version>
<scope>test</scope>
</dependency>
<dependency>
Expand DownExpand Up@@ -341,6 +341,29 @@
</plugins>
</build>
</profile>

<profile>
<id>v24</id>
<properties>
<maven.compiler.source>17</maven.compiler.source>
<maven.compiler.target>17</maven.compiler.target>
<vaadin.version>24.0.0.alpha7</vaadin.version>
<jetty.version>11.0.12</jetty.version>
</properties>
<repositories>
<repository>
<id>vaadin-prerelease</id>
<url>https://maven.vaadin.com/vaadin-prereleases</url>
</repository>
</repositories>
<pluginRepositories>
<pluginRepository>
<id>vaadin-prerelease</id>
<url>https://maven.vaadin.com/vaadin-prereleases</url>
</pluginRepository>
</pluginRepositories>
</profile>

</profiles>

</project>
2 changes: 1 addition & 1 deletion src/main/java/com/flowingcode/vaadin/addons/errorwindow/ErrorWindow.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -176,7 +176,7 @@ private VerticalLayout createMainLayout() {

// copy details to clipboard button
Button clipboarButton = new Button(i18n.getClipboard());
clipboarButton.addThemeVariants(ButtonVariant.LUMO_TERTIARY);
clipboarButton.getThemeNames().add(ButtonVariant.LUMO_TERTIARY.getVariantName());
clipboarButton.addClickListener(e -> UI.getCurrent().getPage()
.executeJs("navigator.clipboard.writeText($0)", getStackTrace()));
clipboarButton.getStyle().set("margin-right", "auto");
Expand Down