Skip to content

refactor: avoid use of commons.lang3#175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mlopezFC merged 3 commits into from
Dec 23, 2025
Merged

refactor: avoid use of commons.lang3 #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
59ad5d4
ci: add vaadin-dev dependency to v25 profile
javier-godoy Dec 23, 2025
2be330b
ci: upgrade to vaadin 25.0.0
javier-godoy Dec 23, 2025
5d54a5c
refactor: avoid use of commons.lang3
javier-godoy Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -540,7 +540,7 @@
<properties>
<maven.compiler.source>21</maven.compiler.source>
<maven.compiler.target>21</maven.compiler.target>
<vaadin.version>25.0.0-beta2</vaadin.version>
<vaadin.version>25.0.0</vaadin.version>
<jetty.version>11.0.26</jetty.version>
</properties>
<dependencies>
Expand All@@ -550,6 +550,11 @@
<version>5.0.0</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.vaadin</groupId>
<artifactId>vaadin-dev</artifactId>
<optional>true</optional>
</dependency>
</dependencies>
</profile>

Expand Down
9 changes: 6 additions & 3 deletions src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMap.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -47,7 +47,6 @@
import java.util.List;
import java.util.concurrent.CompletableFuture;
import lombok.experimental.ExtensionMethod;
import org.apache.commons.lang3.StringUtils;

@SuppressWarnings("serial")
@Tag("google-map")
Expand DownExpand Up@@ -83,14 +82,18 @@ public enum MapType {
*/
public GoogleMap(String apiKey, String clientId, String language) {
getElement().setAttribute("api-key", apiKey);
if (!StringUtils.isEmpty(clientId)) {
if (!isEmpty(clientId)) {
getElement().setAttribute("client-id", clientId);
}
if (!StringUtils.isEmpty(language)) {
if (!isEmpty(language)) {
getElement().setAttribute("language", language);
}
}

private static boolean isEmpty(final String s) {
return s == null || s.length() == 0;
}

@Synchronize("google-map-idle")
public Double getLatitude() {
return getElement().getProperty("latitude", 0d);
Expand Down