Uh oh!
There was an error while loading. Please reload this page.
fix(demo): fix demo styles in vaadin 25 - #21
Conversation
WalkthroughAdded CSS rules to the demo stylesheet to adjust positioning, padding, display, and theming for Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@src/test/resources/META-INF/resources/frontend/styles/granitealert/demo-styles.css`:
- Around line 45-62: The selector "granite-alert-mixin vaadin-button" contains
duplicate and conflicting sizing/position declarations: remove the redundant
height: 26px and margin-top: 0.5px, drop the float: right (since position:
absolute is used), and keep a single sizing strategy (e.g., position: absolute
with height: 100%, top: 0, bottom: 0, right: 0); also remove any other
ineffective or conflicting declarations so the rule is consistent and resolves
stylelint errors.
Uh oh!
There was an error while loading. Please reload this page.
09628da to
9913d77CompareThere was a problem hiding this comment.
🧹 Nitpick comments (1)
src/test/resources/META-INF/resources/frontend/styles/granitealert/demo-styles.css (1)
45-60: Minor redundancy and formatting cleanup.A few small issues remain:
height: 100%is redundant whentop: 0andbottom: 0are both set—they already stretch the element.margin-top: 0.5pxcombined withtop: 0is unusual for absolute positioning; consider usingtop: 0.5pxdirectly if an offset is needed.- Stylelint flags the empty line before
position: absolute;(line 51-52) and expects consistent spacing.🧹 Suggested cleanup
granite-alert-mixin vaadin-button { background-color: transparent; --vaadin-button-background: transparent; cursor: pointer; margin: 0; padding: 0; -+ position: absolute; box-shadow: none; border: none; - height: 100%;- margin-top: 0.5px;- top: 0;+ top: 0.5px; bottom: 0; right: 0; }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/test/resources/META-INF/resources/frontend/styles/granitealert/demo-styles.css` around lines 45 - 60, The granite-alert-mixin vaadin-button rule has redundant and inconsistent declarations: remove height: 100% (top: 0 and bottom: 0 already stretch the element), replace margin-top: 0.5px with top: 0.5px if the vertical offset is required (or remove it if not), and remove the unnecessary blank line before position: absolute to satisfy stylelint spacing rules; update the block in the granite-alert-mixin vaadin-button selector accordingly to keep declarations compact and consistent.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In
`@src/test/resources/META-INF/resources/frontend/styles/granitealert/demo-styles.css`:
- Around line 45-60: The granite-alert-mixin vaadin-button rule has redundant
and inconsistent declarations: remove height: 100% (top: 0 and bottom: 0 already
stretch the element), replace margin-top: 0.5px with top: 0.5px if the vertical
offset is required (or remove it if not), and remove the unnecessary blank line
before position: absolute to satisfy stylelint spacing rules; update the block
in the granite-alert-mixin vaadin-button selector accordingly to keep
declarations compact and consistent.
Uh oh!
There was an error while loading. Please reload this page.



Summary by CodeRabbit