Skip to content

ci: configure vaadin-dev as optional dependency - #170

Merged
paodb merged 1 commit into
masterfrom
javier-godoy-patch-1
Jan 28, 2026
Merged

ci: configure vaadin-dev as optional dependency#170
paodb merged 1 commit into
masterfrom
javier-godoy-patch-1

Conversation

@javier-godoy

@javier-godoyjavier-godoy commented Jan 21, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated build configuration to mark a development dependency as optional.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitaiBot commented Jan 21, 2026

Copy link
Copy Markdown

Walkthrough

Marks the vaadin-dev dependency as optional within the Maven v25 profile by adding an <optional>true</optional> element to its declaration in pom.xml. No logic or control flow changes.

Changes

Cohort / File(s)Summary
Maven Configuration
pom.xml
Modified vaadin-dev dependency in v25 profile to mark as optional by adding <optional>true</optional> element

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • mlopezFC
  • paodb
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately describes the main change: configuring vaadin-dev as an optional dependency in pom.xml, which matches the changeset.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud

Copy link
Copy Markdown

@paodb
paodb merged commit 0e7219c into masterJan 28, 2026
5 checks passed
@github-project-automationgithub-project-automationBot moved this from To Do to Pending release in Flowing Code AddonsJan 28, 2026
@paodb
paodb deleted the javier-godoy-patch-1 branch January 28, 2026 18:26
@javier-godoyjavier-godoy moved this from Pending release to Done in Flowing Code AddonsMar 30, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants

@javier-godoy@paodb