fix: decode node IDs as string in ClientCallable methods

[javier-godoy]

Close#102

Summary by CodeRabbit

• Bug Fixes
  • Improved handling of newly added sibling and child notifications.
  • Ensured comma-separated client IDs are correctly converted and processed, including empty or missing values.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d68996fa-7eac-4fed-a9d3-2d3edcd00040

📥 Commits

Reviewing files that changed from the base of the PR and between 4ee2442 and 7eedcb8.

📒 Files selected for processing (2)

• src/main/java/com/flowingcode/vaadin/addons/orgchart/OrgChart.java
• src/main/resources/META-INF/frontend/fc-orgchart.js

---

Walkthrough

The frontend now sends sibling and child IDs as comma-separated strings. OrgChart converts these strings to JsonArray values before invoking the existing event-processing logic.

Changes

Mutation callback compatibility

Layer / File(s)	Summary
Client ID transport src/main/resources/META-INF/frontend/fc-orgchart.js	Sibling and child callbacks now send comma-separated ID strings.
Server callback conversion src/main/java/com/flowingcode/vaadin/addons/orgchart/OrgChart.java	OrgChart handles string callback parameters, converts IDs to JsonArray values, and delegates to the existing handlers.

Estimated code review effort: 2 (Simple) | ~15 minutes

Mergeability Score:⚪ Minimal · up to 7eedc

The change is limited to decoding node IDs as strings in callable methods, and no actionable merge-blocking risk remains in the supplied evidence.

Possibly related PRs

• FlowingCode/OrgChartAddon#87: Introduced the sibling and child mutation event handlers updated by this change.

Suggested reviewers:paodb

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The changes replace JsonArray RPC parameters with string callbacks and preserve server processing, addressing issue #102 requirements.
Out of Scope Changes check	✅ Passed	All changes relate directly to changing node ID callback decoding for the affected child and sibling operations.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: decoding node IDs as strings in @ClientCallable methods.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix-102

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud