Skip to content

ci: unbreak main test suite - #1750

Merged
nbouliol merged 1 commit into
mainfrom
fix/ci-date-dependent-test-and-unsupported-openai-models
Jul 10, 2026
Merged

ci: unbreak main test suite#1750
nbouliol merged 1 commit into
mainfrom
fix/ci-date-dependent-test-and-unsupported-openai-models

Conversation

@nbouliol

@nbouliolnbouliol commented Jul 10, 2026

Copy link
Copy Markdown
Member

Why

The Lint, Build, Test and Doc workflow has been red on main since 2026-07-09 due to two independent, non-code-regression failures.

Fixes

1. workflow-executor — date-dependent test

load-related-record-step-executor.test.ts asserted the whole select-record prompt not.toContain('-1') to verify the -1 "none" option is withheld when the candidate list is truncated. The prompt embeds the current date (Current date and time: 2026-07-10...), and any date containing the substring -1 (day 10-19, or months 10-12) matched, failing the assertion. Passed on 2026-07-08 (last green run), broke on 2026-07-10.

Fix: assert against the actual none-option text (return -1) rather than the raw -1 substring across the full prompt.

2. ai-proxy — unsupported OpenAI models

gpt-5.6-luna, gpt-5.6-sol, gpt-5.6-terra reject function tools combined with reasoning_effort on v1/chat/completions (they only support v1/responses), failing the llm.integration tool-support test. Added them to OPENAI_UNSUPPORTED_MODELS, per the maintained allow/deny-list convention, plus a unit test.

Test

  • workflow-executor: 102/102 pass
  • ai-proxy supported-models: 8/8 pass

🤖 Generated with Claude Code

Note

Fix CI test suite by blocking gpt-5.6-luna, gpt-5.6-sol, and gpt-5.6-terra from tool support

  • Adds 'gpt-5.6-luna', 'gpt-5.6-sol', and 'gpt-5.6-terra' to OPENAI_UNSUPPORTED_MODELS in supported-models.ts; these models reject reasoning_effort with function tools on v1/chat/completions.
  • Updates a test assertion in load-related-record-step-executor.test.ts to check for absence of 'return -1' rather than '-1'.
📊 Macroscope summarized 8cfea08. 1 file reviewed, 0 issues evaluated, 0 issues filtered, 0 comments posted

🗂️ Filtered Issues

No issues evaluated.

- workflow-executor: the truncation guard test asserted the whole
select-record prompt does not contain '-1', but the prompt embeds the
current date; any date with '-1' as a substring (e.g. 2026-07-10)
matched and failed the assertion. Target the actual none-option text
('return -1') instead.
- ai-proxy: denylist gpt-5.6-luna/sol/terra, which reject function tools
with reasoning_effort on v1/chat/completions (v1/responses only).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Comment on lines +49 to 53
// Reject reasoning_effort with function tools on v1/chat/completions (v1/responses only)
'gpt-5.6-luna',
'gpt-5.6-sol',
'gpt-5.6-terra',
];

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Mediumsrc/supported-models.ts:49

Adding gpt-5.6-luna, gpt-5.6-sol, and gpt-5.6-terra to OPENAI_UNSUPPORTED_MODELS causes isModelSupportingTools() to return false for all three models, even though they support function calling via v1/chat/completions. This blocks users from configuring these models entirely — any config referencing them is rejected with AIModelNotSupportedError during router construction, including plain chat requests and tool calls that don't use reasoning_effort. If the issue is specifically that reasoning_effort is rejected when combined with function tools on v1/chat/completions, a blanket model block is too broad. Consider handling that restriction at the request level (e.g., erroring only when reasoning_effort and function tools are combined) rather than marking the models fully unsupported.

 'us-40-51r-vm-ev3', // Not a chat model (v1/completions only)
- // Reject reasoning_effort with function tools on v1/chat/completions (v1/responses only)- 'gpt-5.6-luna',- 'gpt-5.6-sol',- 'gpt-5.6-terra',
🚀 Reply "fix it for me" or copy this AI Prompt for your agent:
In file @packages/ai-proxy/src/supported-models.ts around lines 49-53:
Adding `gpt-5.6-luna`, `gpt-5.6-sol`, and `gpt-5.6-terra` to `OPENAI_UNSUPPORTED_MODELS` causes `isModelSupportingTools()` to return `false` for all three models, even though they support function calling via `v1/chat/completions`. This blocks users from configuring these models entirely — any config referencing them is rejected with `AIModelNotSupportedError` during router construction, including plain chat requests and tool calls that don't use `reasoning_effort`. If the issue is specifically that `reasoning_effort` is rejected when combined with function tools on `v1/chat/completions`, a blanket model block is too broad. Consider handling that restriction at the request level (e.g., erroring only when `reasoning_effort` and function tools are combined) rather than marking the models fully unsupported.

@nbouliolnbouliol changed the title fix(ci): unbreak main test suiteci: unbreak main test suiteJul 10, 2026
@qltysh

qltyshBot commented Jul 10, 2026

Copy link
Copy Markdown

Qlty


Coverage Impact

⬆️ Merging this pull request will increase total coverage on main by 0.03%.

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@nbouliol
nbouliol merged commit 2f14ca0 into mainJul 10, 2026
37 checks passed
@nbouliol
nbouliol deleted the fix/ci-date-dependent-test-and-unsupported-openai-models branch July 10, 2026 09:43
Scra3 pushed a commit that referenced this pull request Jul 10, 2026
…s API
The deny-list from #1750 worked around the chat/completions 400; the
Responses switch makes these models pass tool calling again.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@nbouliol@Scra3@hercemer42