fix(workflow-executor): accept triggerType='mcp' in run mapper (PRD-832)

[christophebrun-forest]

Description

Foundational fix for MCP workflow triggering (epic PRD-49).

A workflow run triggered via MCP carries triggerType='mcp', but @forestadmin/workflow-executor only recognized manual | webhook. The run mapper validates the value against AvailableStepExecutionSchema, so every MCP-triggered run failed at step 0 before executing:

error Malformed run reported as error runId="438" stepIndex=0
error="Run 438 mapper produced invalid AvailableStepExecution — triggerType: Invalid option: expected one of \"manual\"|\"webhook\""

Surfaced in the Forest UI as:

Internal validation error occurred while preparing the step. Please contact support.

Root cause

triggerType is informational only in the executor — its sole consumer is a Debug log context in runner.ts; no execution logic branches on it. The run was aborted purely because of an unrecognized value in a logged field.

Fix

• TriggerType (src/types/validated/execution.ts) — add Mcp = 'mcp'
• ServerWorkflowTriggerType (src/adapters/server-types.ts) — add mcp = 'mcp'

Strict-enum approach, consistent with the executor's convention of mirroring the server contract. Unknown trigger types still fail loudly.

Tests

Added a mapper test asserting an mcp-triggered run maps to a valid AvailableStepExecution with triggerType preserved (no downgrade to manual). Full suite green (1469 passed), lint clean.

Notes

• Discovered while testing the MCP discover → trigger → poll flow end-to-end; unblocks PRD-740 validation.
• Follow-up idea: since triggerType is only logged, a drift-tolerant passthrough could avoid breaking on future server trigger types (scheduled, api, …).

fixes PRD-832

🤖 Generated with Claude Code

Note

Accept triggerType='mcp' in workflow executor run mapper

Adds mcp as a valid trigger type across the workflow executor by adding Mcp = 'mcp' to the TriggerType enum in execution.ts and mcp to ServerWorkflowTriggerType in server-types.ts. The run-to-available-step mapper now correctly maps ServerWorkflowTriggerType.mcp to TriggerType.Mcp, covered by a new test case.

^{Macroscope summarized 249bbb9.}

[linear-code]

PRD-832

[qltysh]

Coverage Impact

Unable to calculate total coverage change because base branch coverage was not found.

Modified Files with Diff Coverage (2)

Rating	File	% Diff	Uncovered Line #s
	packages/workflow-executor/src/types/validated/execution.ts	100.0%
	packages/workflow-executor/src/adapters/server-types.ts	100.0%
	Total	100.0%

🚦 See full report on Qlty Cloud »

🛟 Help

• Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

• Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

• File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

  • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.