GameStateConverter: Add some extra information about cards

[cdaymand]

All these new information are needed to create a card description for slaythecli

[ForgottenArbiter]

Thanks for the pull request! I agree that these are some good things to have. Originally, the description, damage, block, and magic number were left out because it was possible to determine them from the rest of the game state, and I wanted to keep the state representation small. However, in the interest of not adding too much extra information to the game state (especially considering a large portion is often taken up by card objects, and it all needs to be transmitted over stdout), could we reduce the number of new fields? I was thinking:

• baseHeal, baseDraw, and baseDiscard are not used by the game, so they could be removed, along with heal, draw, and discard
• I don't believe base_magic_number and magic_number are both necessary, since I'm pretty sure they are always equal. I'll leave this one up to you, though.
• While you're at it, do you want to add ethereal? I've had that requested before, and for some reason I added exhaust, so ethereal is definitely in the same vein.

I do see why users might want both base_block and block though (same with damage). Also let me know if you think my concerns are completely unfounded.

[cdaymand]

At first when I did these changes, I was not completely sure about the information needed, now I am a bit more confident about the game source code and I agree for baseDraw and baseDiscard (not needed)
For the card feed, I will check if baseHeal is used or not.
Someone contacts on reddit about ethereal and yes it might be interesting to add.
Yes base_block and base_damage is needed when displaying deck or card reward because then damage and block is at value -1.
I will modify my pull request.

In fact at the moment, after reading a post on reddit (regarding accessibility) I changed a bit my mind and I am completely doing the server part in java which handles all the game logic and send back a nice output.
This way the installation will be easier for people (just a mod) and the game will be playable by any tcp client, telnet, socat, nc , ...
I think I might have something soon to share.

[cdaymand]

All these new information are needed to create a card description for slaythecli

[ForgottenArbiter]

Thanks for the pull request! I agree that these are some good things to have. Originally, the description, damage, block, and magic number were left out because it was possible to determine them from the rest of the game state, and I wanted to keep the state representation small. However, in the interest of not adding too much extra information to the game state (especially considering a large portion is often taken up by card objects, and it all needs to be transmitted over stdout), could we reduce the number of new fields? I was thinking:

• baseHeal, baseDraw, and baseDiscard are not used by the game, so they could be removed, along with heal, draw, and discard
• I don't believe base_magic_number and magic_number are both necessary, since I'm pretty sure they are always equal. I'll leave this one up to you, though.
• While you're at it, do you want to add ethereal? I've had that requested before, and for some reason I added exhaust, so ethereal is definitely in the same vein.

I do see why users might want both base_block and block though (same with damage). Also let me know if you think my concerns are completely unfounded.

[cdaymand]

At first when I did these changes, I was not completely sure about the information needed, now I am a bit more confident about the game source code and I agree for baseDraw and baseDiscard (not needed)
For the card feed, I will check if baseHeal is used or not.
Someone contacts on reddit about ethereal and yes it might be interesting to add.
Yes base_block and base_damage is needed when displaying deck or card reward because then damage and block is at value -1.
I will modify my pull request.

In fact at the moment, after reading a post on reddit (regarding accessibility) I changed a bit my mind and I am completely doing the server part in java which handles all the game logic and send back a nice output.
This way the installation will be easier for people (just a mod) and the game will be playable by any tcp client, telnet, socat, nc , ...
I think I might have something soon to share.

[cdaymand]

All these new information are needed to create a card description for slaythecli

[ForgottenArbiter]

Thanks for the pull request! I agree that these are some good things to have. Originally, the description, damage, block, and magic number were left out because it was possible to determine them from the rest of the game state, and I wanted to keep the state representation small. However, in the interest of not adding too much extra information to the game state (especially considering a large portion is often taken up by card objects, and it all needs to be transmitted over stdout), could we reduce the number of new fields? I was thinking:

• baseHeal, baseDraw, and baseDiscard are not used by the game, so they could be removed, along with heal, draw, and discard
• I don't believe base_magic_number and magic_number are both necessary, since I'm pretty sure they are always equal. I'll leave this one up to you, though.
• While you're at it, do you want to add ethereal? I've had that requested before, and for some reason I added exhaust, so ethereal is definitely in the same vein.

I do see why users might want both base_block and block though (same with damage). Also let me know if you think my concerns are completely unfounded.

[cdaymand]

At first when I did these changes, I was not completely sure about the information needed, now I am a bit more confident about the game source code and I agree for baseDraw and baseDiscard (not needed)
For the card feed, I will check if baseHeal is used or not.
Someone contacts on reddit about ethereal and yes it might be interesting to add.
Yes base_block and base_damage is needed when displaying deck or card reward because then damage and block is at value -1.
I will modify my pull request.

In fact at the moment, after reading a post on reddit (regarding accessibility) I changed a bit my mind and I am completely doing the server part in java which handles all the game logic and send back a nice output.
This way the installation will be easier for people (just a mod) and the game will be playable by any tcp client, telnet, socat, nc , ...
I think I might have something soon to share.

[cdaymand]

All these new information are needed to create a card description for slaythecli

[ForgottenArbiter]

Thanks for the pull request! I agree that these are some good things to have. Originally, the description, damage, block, and magic number were left out because it was possible to determine them from the rest of the game state, and I wanted to keep the state representation small. However, in the interest of not adding too much extra information to the game state (especially considering a large portion is often taken up by card objects, and it all needs to be transmitted over stdout), could we reduce the number of new fields? I was thinking:

• baseHeal, baseDraw, and baseDiscard are not used by the game, so they could be removed, along with heal, draw, and discard
• I don't believe base_magic_number and magic_number are both necessary, since I'm pretty sure they are always equal. I'll leave this one up to you, though.
• While you're at it, do you want to add ethereal? I've had that requested before, and for some reason I added exhaust, so ethereal is definitely in the same vein.

I do see why users might want both base_block and block though (same with damage). Also let me know if you think my concerns are completely unfounded.

[cdaymand]

At first when I did these changes, I was not completely sure about the information needed, now I am a bit more confident about the game source code and I agree for baseDraw and baseDiscard (not needed)
For the card feed, I will check if baseHeal is used or not.
Someone contacts on reddit about ethereal and yes it might be interesting to add.
Yes base_block and base_damage is needed when displaying deck or card reward because then damage and block is at value -1.
I will modify my pull request.

In fact at the moment, after reading a post on reddit (regarding accessibility) I changed a bit my mind and I am completely doing the server part in java which handles all the game logic and send back a nice output.
This way the installation will be easier for people (just a mod) and the game will be playable by any tcp client, telnet, socat, nc , ...
I think I might have something soon to share.

[cdaymand]

All these new information are needed to create a card description for slaythecli

[ForgottenArbiter]

Thanks for the pull request! I agree that these are some good things to have. Originally, the description, damage, block, and magic number were left out because it was possible to determine them from the rest of the game state, and I wanted to keep the state representation small. However, in the interest of not adding too much extra information to the game state (especially considering a large portion is often taken up by card objects, and it all needs to be transmitted over stdout), could we reduce the number of new fields? I was thinking:

• baseHeal, baseDraw, and baseDiscard are not used by the game, so they could be removed, along with heal, draw, and discard
• I don't believe base_magic_number and magic_number are both necessary, since I'm pretty sure they are always equal. I'll leave this one up to you, though.
• While you're at it, do you want to add ethereal? I've had that requested before, and for some reason I added exhaust, so ethereal is definitely in the same vein.

I do see why users might want both base_block and block though (same with damage). Also let me know if you think my concerns are completely unfounded.

[cdaymand]

At first when I did these changes, I was not completely sure about the information needed, now I am a bit more confident about the game source code and I agree for baseDraw and baseDiscard (not needed)
For the card feed, I will check if baseHeal is used or not.
Someone contacts on reddit about ethereal and yes it might be interesting to add.
Yes base_block and base_damage is needed when displaying deck or card reward because then damage and block is at value -1.
I will modify my pull request.

In fact at the moment, after reading a post on reddit (regarding accessibility) I changed a bit my mind and I am completely doing the server part in java which handles all the game logic and send back a nice output.
This way the installation will be easier for people (just a mod) and the game will be playable by any tcp client, telnet, socat, nc , ...
I think I might have something soon to share.

[cdaymand]

All these new information are needed to create a card description for slaythecli

[ForgottenArbiter]

Thanks for the pull request! I agree that these are some good things to have. Originally, the description, damage, block, and magic number were left out because it was possible to determine them from the rest of the game state, and I wanted to keep the state representation small. However, in the interest of not adding too much extra information to the game state (especially considering a large portion is often taken up by card objects, and it all needs to be transmitted over stdout), could we reduce the number of new fields? I was thinking:

• baseHeal, baseDraw, and baseDiscard are not used by the game, so they could be removed, along with heal, draw, and discard
• I don't believe base_magic_number and magic_number are both necessary, since I'm pretty sure they are always equal. I'll leave this one up to you, though.
• While you're at it, do you want to add ethereal? I've had that requested before, and for some reason I added exhaust, so ethereal is definitely in the same vein.

I do see why users might want both base_block and block though (same with damage). Also let me know if you think my concerns are completely unfounded.

[cdaymand]

At first when I did these changes, I was not completely sure about the information needed, now I am a bit more confident about the game source code and I agree for baseDraw and baseDiscard (not needed)
For the card feed, I will check if baseHeal is used or not.
Someone contacts on reddit about ethereal and yes it might be interesting to add.
Yes base_block and base_damage is needed when displaying deck or card reward because then damage and block is at value -1.
I will modify my pull request.

In fact at the moment, after reading a post on reddit (regarding accessibility) I changed a bit my mind and I am completely doing the server part in java which handles all the game logic and send back a nice output.
This way the installation will be easier for people (just a mod) and the game will be playable by any tcp client, telnet, socat, nc , ...
I think I might have something soon to share.

[cdaymand]

All these new information are needed to create a card description for slaythecli

[ForgottenArbiter]

Thanks for the pull request! I agree that these are some good things to have. Originally, the description, damage, block, and magic number were left out because it was possible to determine them from the rest of the game state, and I wanted to keep the state representation small. However, in the interest of not adding too much extra information to the game state (especially considering a large portion is often taken up by card objects, and it all needs to be transmitted over stdout), could we reduce the number of new fields? I was thinking:

• baseHeal, baseDraw, and baseDiscard are not used by the game, so they could be removed, along with heal, draw, and discard
• I don't believe base_magic_number and magic_number are both necessary, since I'm pretty sure they are always equal. I'll leave this one up to you, though.
• While you're at it, do you want to add ethereal? I've had that requested before, and for some reason I added exhaust, so ethereal is definitely in the same vein.

I do see why users might want both base_block and block though (same with damage). Also let me know if you think my concerns are completely unfounded.

[cdaymand]

At first when I did these changes, I was not completely sure about the information needed, now I am a bit more confident about the game source code and I agree for baseDraw and baseDiscard (not needed)
For the card feed, I will check if baseHeal is used or not.
Someone contacts on reddit about ethereal and yes it might be interesting to add.
Yes base_block and base_damage is needed when displaying deck or card reward because then damage and block is at value -1.
I will modify my pull request.

In fact at the moment, after reading a post on reddit (regarding accessibility) I changed a bit my mind and I am completely doing the server part in java which handles all the game logic and send back a nice output.
This way the installation will be easier for people (just a mod) and the game will be playable by any tcp client, telnet, socat, nc , ...
I think I might have something soon to share.

[cdaymand]

All these new information are needed to create a card description for slaythecli

[ForgottenArbiter]

Thanks for the pull request! I agree that these are some good things to have. Originally, the description, damage, block, and magic number were left out because it was possible to determine them from the rest of the game state, and I wanted to keep the state representation small. However, in the interest of not adding too much extra information to the game state (especially considering a large portion is often taken up by card objects, and it all needs to be transmitted over stdout), could we reduce the number of new fields? I was thinking:

• baseHeal, baseDraw, and baseDiscard are not used by the game, so they could be removed, along with heal, draw, and discard
• I don't believe base_magic_number and magic_number are both necessary, since I'm pretty sure they are always equal. I'll leave this one up to you, though.
• While you're at it, do you want to add ethereal? I've had that requested before, and for some reason I added exhaust, so ethereal is definitely in the same vein.

I do see why users might want both base_block and block though (same with damage). Also let me know if you think my concerns are completely unfounded.

[cdaymand]

At first when I did these changes, I was not completely sure about the information needed, now I am a bit more confident about the game source code and I agree for baseDraw and baseDiscard (not needed)
For the card feed, I will check if baseHeal is used or not.
Someone contacts on reddit about ethereal and yes it might be interesting to add.
Yes base_block and base_damage is needed when displaying deck or card reward because then damage and block is at value -1.
I will modify my pull request.

In fact at the moment, after reading a post on reddit (regarding accessibility) I changed a bit my mind and I am completely doing the server part in java which handles all the game logic and send back a nice output.
This way the installation will be easier for people (just a mod) and the game will be playable by any tcp client, telnet, socat, nc , ...
I think I might have something soon to share.