[pull] main from spring-projects:main - #6
Merged
Conversation
OpenAI's strict function-calling mode requires "additionalProperties": false on every object level of a tool's input schema, and rejects the request otherwise. applyStrictModeRequirements backfills "required" and widens optional properties to nullable types, but never emitted "additionalProperties": false. Schemas produced by JsonSchemaGenerator already carry it, so the gap only bites schemas from other sources under strict mode: MCP tool schemas, hand-written inputSchema JSON, or schemas generated with ALLOW_ADDITIONAL_PROPERTIES_BY_DEFAULT. Backfill "additionalProperties": false on every object level the strict-mode rewrite already recurses through (root, $defs definitions, nested object properties, array items), preserving an explicitly declared value such as a Map<K,V>-style typed "additionalProperties", mirroring the guard in JsonSchemaGenerator#forbidAdditionalProperties. Schemas sent with strict(false) are untouched. See #4422 Signed-off-by: James Lewis <1495031+JamesBLewis@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )