Skip to content
This repository was archived by the owner on Mar 4, 2022. It is now read-only.
This repository was archived by the owner on Mar 4, 2022. It is now read-only.

[BUG] Windows: MinGW/Git Bash/Etc. use PATH env var instead of Path like cmd does. #142

Description

@rhbecker

I see the above error with the following setup:

  • builder v3.2.2
  • node v6.11.0
  • windows 10
  • executing in git-bash, cygwin, etc.

These same issues do not occur via cmd.

If you have such an environment, you can repro via npm run builder:check, which yields ...

  • 78 passing
  • 8 pending
  • 11 failing

So far, I have no explanation - only observations ...

All 11 failing tests call an npm script defined to include ...
"node test/server/fixtures/echo.js ..."
... but there are 4 tests that pass with the same script.

The difference is that the 11 failing ones invoke the script via run or concurrent, while the 4 passing ones invoke with envs.

Don't pass:

  • run({argv: ["node", "builder", "run", "echo", ...]}, ...});
  • run({argv: ["node", "builder", "concurrent", "echo", ...]}, ...});

Pass:

  • run({argv: ["node", "builder", "envs", "echo", ...]}, ...});

So, you might think any script invoked via run that calls node whatever might fail, but that is not the case. The "runs with --setup" test passes. It defines an npm script ...

"bar": "node test/server/fixtures/repeat-script.js 5 BAR_TASK >> stdout.log"

... which it calls via ...

run({argv: ["node", "builder", "run", "bar", "--setup=setup"]}, ...});

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions