Skip to content
This repository was archived by the owner on Feb 18, 2022. It is now read-only.
This repository was archived by the owner on Feb 18, 2022. It is now read-only.

Tunajs bypass property propType assigned as number #54

Description

@aalises

Hello!
Thanks for this amazing project 🎼 I have noted that in the effects file, the tunaJS bypass propTypes are set as propTypes.number. Shouldn't it be propTypes.bool?
Test file of the tunaJS library where the bypass properties are assigned as booleans

Should we change the proptypes of the bypass property to be boolean, from number? Also, It would be nice to implement the Phaser effect (I used it a lot). I can make a pull request adding the phaser effect and correcting the propTypes today, WDYT?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions