Skip to content

Do not compile nofile_limit util functions on Windows - #30

Merged
icota merged 3 commits into
mainfrom
fix-windows-build
Jan 22, 2024
Merged

icota merged 3 commits into
mainfrom
fix-windows-build

Conversation

@icota

@icota icota commented Jan 22, 2024

Copy link
Copy Markdown
Contributor

Should fix #29

@icota icota mentioned this pull request Jan 22, 2024
@H3mnz

H3mnz commented Jan 22, 2024

Copy link
Copy Markdown

With comment this lines in rust/src/lib.rs

pub use crate::util::tor_get_nofile_limit;
pub use crate::util::tor_set_nofile_limit;

it works on the windows

@icota

icota commented Jan 22, 2024

Copy link
Copy Markdown
Contributor Author

Thank you for testing @H3mnz. Does it now work without you making any changes in b8dcfef?

@H3mnz

H3mnz commented Jan 22, 2024

Copy link
Copy Markdown

Yes, it works in b8dcfef

@icota
icota merged commit b31e4db into main Jan 22, 2024
sneurlax referenced this pull request in cypherstack/tor Jun 13, 2024
7a5bba8 fix: setup flutter environment for Xcode iOS builds (#30)
7467b9a fix: build_pod.sh should setup flutter environment (#29)
0f0359e fix: install targets for correct toolchain (#26)

git-subtree-dir: cargokit
git-subtree-split: 7a5bba8eefbfe7e567f754477fd172e7a06b153f
sneurlax referenced this pull request in cypherstack/tor Jun 22, 2024
7a5bba8 fix: setup flutter environment for Xcode iOS builds (#30)

git-subtree-dir: cargokit
git-subtree-split: 7a5bba8eefbfe7e567f754477fd172e7a06b153f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failed on the windows

2 participants