Uh oh!
There was an error while loading. Please reload this page.
[Custom Properties] Feat: delete/edit custom property - #1329
Merged
tonypizzicato merged 27 commits intoApr 26, 2017
Merged
Conversation
tonypizzicato
suggested changes
Apr 18, 2017
tonypizzicato
left a comment
Contributor
There was a problem hiding this comment.
It's ok, except one comment
| right: 21px; | ||
| & > i { | ||
| margin: 0 5px; |
| get deletePropertyForm () { | ||
| if (this.state.isDeletingProperty) { | ||
| return ( | ||
| <DeletePropertyModal |
Contributor
There was a problem hiding this comment.
you can use ConfirmationDialog here instead self-written one
https://github.com/FoxComm/highlander/blob/master/ashes/src/components/images/image.jsx#L75
Contributor
There was a problem hiding this comment.
but i'm not sure that BodyPortal usage is required there
Conflicts: ashes/src/components/products/custom-property.jsx
tonypizzicato
approved these changes
Apr 26, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge only after fix PATCH query on the backend.