Uh oh!
There was an error while loading. Please reload this page.
Add configs for the search service - #2182
Conversation
| phoenix_tax_rule_rate: 7.5 | ||
| # Agni | ||
| agni_src: ../../search-service |
There was a problem hiding this comment.
Should we rename search-service dir to agni then?
There was a problem hiding this comment.
I think yes, but we can do it in next PR, when you finish the draft of DSL (to avoid conflicts).
| }, | ||
| "env": { | ||
| "PORT": "{{agni_port}}", | ||
| "SEARCH_SERVER": "" |
There was a problem hiding this comment.
That should not be empty afaik, as it points to elastic search instance which is crucial for search-service/agni to work
| {% include "core-backend/isaac.json.j2" %}, | ||
| {% include "core-backend/solomon.json.j2" %}, | ||
| {% include "core-backend/middlewarehouse.json.j2" %} | ||
| {% include "core-backend/agni.json.j2" %} |
63b2e8c to
11c2d22Compare
eugene-sy
left a comment
There was a problem hiding this comment.
In general it looks good.
Except comments in the code, could you add ability to change service port in the resource file?
| }, | ||
| "ports": [{{agni_port}}], | ||
| "healthChecks": [{ | ||
| "path": "/ping", |
There was a problem hiding this comment.
AFAIK we don't have /ping endpoint right now, health check will be failed and it will break deployment.
I think it's a good idea to change it to consumer/greenriver health check (by process) or implement the endpoint
There was a problem hiding this comment.
Yep, I think it's better to implement the endpoint
There was a problem hiding this comment.
Yep, saw that. Tested already, thanks!
feb45a6 to
010ea20Comparef1aa2d4 to
2241db3Compare
2241db3 to
e7b3418Compare| "maximumOverCapacity": 0 | ||
| }, | ||
| "env": { | ||
| "PORT": "{{agni_port}}", |
There was a problem hiding this comment.
I believe it can work on a random port. Why do we need to specify it explicitly?
There was a problem hiding this comment.
You know, I'm not sure why 🙂
I'll change it to a random port
There was a problem hiding this comment.
I believe all marathon apps should use port from env PORT to be compatible with them.
| "SEARCH_SERVER": "elasticsearch://{{search_server}}", | ||
| "JAVA_OPTS":"-XX:+UseConcMarkSweepGC -Xms512m -Xmx512m" | ||
| }, | ||
| "ports": [{{agni_port}}], |
No description provided.