Uh oh!
There was an error while loading. Please reload this page.
[Ashes] Move DateTime to utils - #2228
Conversation
Conflicts: ashes/src/components/gift-cards/gift-card.jsx ashes/src/components/rmas/helpers.jsx ashes/src/components/table/cell.jsx ashes/styleguide/config.styleguide.js
| * | ||
| * @function Moment | ||
| */ | ||
| export const Moment = ({ |
There was a problem hiding this comment.
let's get rid of exporting Moment to the outside world(also specs and examples from styleguide) to restrict ability to use different formats. looks like it's not used anywhere(https://github.com/FoxComm/highlander/blob/master/ashes/src/components/table/cell.jsx#L34 is the only place, but looks like it is unreachable, can you check it one more time?)
There was a problem hiding this comment.
yep, looks like there is no type: 'moment'used in the project.
| it('should render date/time in (L LTS) format by default', function () { | ||
| const date = '2017-12-29T15:10:30'; | ||
| const expectedResult = moment.utc(date).local().format('L LTS'); |
There was a problem hiding this comment.
looks like this expression is an internal of Moment itself, so expect(datetime.text()).to.equal(expectedResult); asserts that internals of Moment equal to the result of <Moment> call.
i think it should be smth like
const date = '2017-12-29T15:10:30';
const expectedResult = '12/29/2017 3:10 PM';
const datetime = mount(
<DateTime.Moment value={date} />
);
expect(datetime.text()).to.equal(expectedResult);
| type Props = { | ||
| /** time string */ | ||
| value?: string, |
| }; | ||
| export const DateTime = (props: Props) => <Moment {...props} format={'L LT'} />; |
There was a problem hiding this comment.
these components props type is not the same as Moment's props - it doesn't accept format
type DateTimeProps = {
value: string,
utc?: boolean,
emptyValue?: string,
className?: string
}
type MomentProps = DateTimeProps & {
format: string,
};
| #### Basic usage | ||
| ```javascript | ||
| <DateTime value={1497636772107} /> |
There was a problem hiding this comment.
Props type of Moment says that value type is string
Conflicts: ashes/src/components/common/datetime.jsx
remove unused css
add describe for DateTime, Date, Time
What was done:
datetime.jsxmoved to/utilsreplace propTypes with Flow
add components to Styleguide
add tests