Uh oh!
There was an error while loading. Please reload this page.
Add JAVA_OPTS to search service docker image cmd - #2255
Merged
Conversation
kairome
reviewed
Jun 20, 2017
| .from("openjdk:8-alpine") | ||
| .add(artifact, artifactTargetPath) | ||
| .cmdRaw(s"java -jar $artifactTargetPath") | ||
| .cmdRaw(s"java $$JAVA_OPTS -jar $artifactTargetPath 2>&1 | tee /logs/${appName.value}.log") |
| .from("openjdk:8-alpine") | ||
| .add(artifact, artifactTargetPath) | ||
| .cmdRaw(s"java -jar $artifactTargetPath") | ||
| .cmdRaw(s"java $$JAVA_OPTS -jar $artifactTargetPath 2>&1 | tee -a /logs/${appName.value}.log") |
ContributorAuthor
There was a problem hiding this comment.
$ has special meaning in Scala's string interpolation (to refer to any identifier in scope). To escape it I need to type it twice.
Contributor
There was a problem hiding this comment.
ok, it was my guess, but I wanted to double check.
eugene-sy
commented
Jun 20, 2017
Contributor
LGTM, let's merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.