Uh oh!
There was an error while loading. Please reload this page.
Feature/schema registry in geronimo - #2278
Open
retgoat wants to merge 15 commits into
Open
Conversation
Signed-off-by: Roman Sotnikov <roman.sotnikov@gmail.com>
Signed-off-by: Roman Sotnikov <roman.sotnikov@gmail.com>
Signed-off-by: Roman Sotnikov <roman.sotnikov@gmail.com>
Signed-off-by: Roman Sotnikov <roman.sotnikov@gmail.com>
Signed-off-by: Roman Sotnikov <roman.sotnikov@gmail.com>
Signed-off-by: Roman Sotnikov <roman.sotnikov@gmail.com>
Signed-off-by: Roman Sotnikov <roman.sotnikov@gmail.com>
Signed-off-by: Roman Sotnikov <roman.sotnikov@gmail.com>
Signed-off-by: Roman Sotnikov <roman.sotnikov@gmail.com>
Signed-off-by: Roman Sotnikov <roman.sotnikov@gmail.com>
eugene-sy
left a comment
Contributor
There was a problem hiding this comment.
I don't see any code related problems here.
Other than that, I'd suggest to use timestamps in migration file names.
| reset: | ||
| @make drop-db | ||
| dropdb --if-exists $(DB_TEST) -U $(DB_USER) |
Contributor
There was a problem hiding this comment.
Given that we have drop-db, shall we create drop-test-db too?
ContributorAuthor
There was a problem hiding this comment.
Actually no. We dropping test DB here because in other case we can not drop development DB cause it belongs to geronimo DB user as well.
We creating test DB in reset-test task.
| ```json | ||
| { | ||
| "content_type_id": 1, | ||
| "storefront": "theperfectgourmet.com", |
Contributor
There was a problem hiding this comment.
I'm not sure that it's good idea to put a link to the customers website. We could use something more context neutral.
Signed-off-by: Roman Sotnikov <roman.sotnikov@gmail.com>
Signed-off-by: Roman Sotnikov <roman.sotnikov@gmail.com>
Signed-off-by: Roman Sotnikov <roman.sotnikov@gmail.com>
Signed-off-by: Roman Sotnikov <roman.sotnikov@gmail.com>
Signed-off-by: Roman Sotnikov <roman.sotnikov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.