Uh oh!
There was an error while loading. Please reload this page.
Query dsl improvements - #2286
Merged
aafa merged 7 commits intoJun 29, 2017
Merged
Conversation
kjanoszforce-pushed
the
search-service/query-dsl-improvements
branch
from
June 23, 2017 11:12
8d7c1e7 to
2b7f749CompareAllow to specify nested fields in query functions. Change folding over coproduct. Remove monad constraint from query interpreter. Refactor code around.
kjanoszforce-pushed
the
search-service/query-dsl-improvements
branch
from
June 26, 2017 09:53
2b7f749 to
5f7e0e7Comparekjanoszforce-pushed
the
search-service/query-dsl-improvements
branch
from
June 27, 2017 11:27
9a47c8a to
e0f7e2eCompareFix bool and raw query functions translation. Change boost to be set per function type instead of a context.
aafa
approved these changes
Jun 29, 2017
aafa
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Queries do look fairly advanced now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've also refactored
ESQueryInterpreterto enforce more purity. More principled way would be to useStateT, but since our input state is mutable (BoolQueryBuilder) there is no reason imho to use state monad and have it modeled as e.gState[BoolQueryBuilder, ()]orState[BoolQueyrBuilder, BoolQueryBuilder].Also, inside the interpreter I've used the
Idmonad instead of some real one (likeCoeval) to avoid additional allocations, and wrap it only when we actually run it - please seepackage objectof theespackage.