Uh oh!
There was an error while loading. Please reload this page.
Move around some stuff in core._ - #2313
Open
michalrus wants to merge 2 commits into
Open
Conversation
(A couple of FIXMEs as a nice break from bugs :P)
michalrus
commented
Jun 27, 2017
| def doOrMeh(condition: Boolean, action: ⇒ DbResultT[_])(implicit ec: EC): DbResultT[Unit] = | ||
| if (condition) action.meh else DbResultT.unit | ||
| def when[F[_]](p: Boolean, s: ⇒ F[Unit])(implicit F: Applicative[F]): F[Unit] = |
ContributorAuthor
There was a problem hiding this comment.
| def appendForUpdate[A, B <: slick.dbio.NoStream](sql: SqlAction[A, B, Effect.Read]): DBIO[A] = | ||
| sql.overrideStatements(sql.statements.map(_ + " for update")) | ||
| def lift[A](value: A): DBIO[A] = DBIO.successful(value) |
ContributorAuthor
There was a problem hiding this comment.
Not needed, we have pure from cats.
| def apply[A](a: A)(implicit F: Monad[F]): FoxyT[F, A] = // TODO: remove me? @michalrus | ||
| pure(a) | ||
| def pure[A](a: A)(implicit F: Monad[F]): FoxyT[F, A] = |
ContributorAuthor
There was a problem hiding this comment.
Not needed, we have pure from cats.
| } | ||
| trait FoxyTFunctions[F[_]] { | ||
| def apply[A](a: A)(implicit F: Monad[F]): FoxyT[F, A] = // TODO: remove me? @michalrus |
narma
commented
Jun 27, 2017
Contributor
FMT! |
michalrus
commented
Jun 28, 2017
ContributorAuthor
Yikes! |
michalrus
commented
Jun 28, 2017
| for { | ||
| failures ← * <~ IlluminateAlgorithm.validateAttributes(fs.form.attributes, fs.shadow.attributes) | ||
| _ ← * <~ failIfFailures(failures) | ||
| _ ← * <~ failIfFailures[DBIO](failures) // TODO: why no inference? @michalrus |
narma
approved these changes
Nov 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(A couple of FIXMEs as a nice break from bugs :P)