Skip to content

Fix prop mutation - #2323

Merged
tonypizzicato merged 1 commit into
feature/ashes-styleguide-phase-3from
fix/1899-address-bug
Jun 29, 2017
Merged

Fix prop mutation#2323
tonypizzicato merged 1 commit into
feature/ashes-styleguide-phase-3from
fix/1899-address-bug

Conversation

@Diokuz

@DiokuzDiokuz commented Jun 29, 2017

Copy link
Copy Markdown
Contributor

What was done

  1. Replace accumulator props.address → clone(props.address) to prevent props mutation.

@DiokuzDiokuz self-assigned this Jun 29, 2017
@DiokuzDiokuz mentioned this pull request Jun 29, 2017
Open
@tonypizzicato

tonypizzicato commented Jun 29, 2017

Copy link
Copy Markdown
Contributor

👍

@tonypizzicato
tonypizzicato merged commit 94201f8 into feature/ashes-styleguide-phase-3Jun 29, 2017
@tonypizzicato
tonypizzicato deleted the fix/1899-address-bug branch June 29, 2017 13:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tonypizzicatotonypizzicatoAwaiting requested review from tonypizzicato
1 more reviewer
@eugene-syeugene-syeugene-sy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready to reviewTeam: Admin [Tony]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Diokuz@tonypizzicato@eugene-sy