Skip to content

refactor(app): remove legacy shell and onboarding layouts - #42

Closed
Foxpace wants to merge 1 commit into
codex/sensorbox-refactor-28-phone-advanced-layoutsfrom
codex/sensorbox-refactor-29-phone-shell-layouts
Closed

refactor(app): remove legacy shell and onboarding layouts#42
Foxpace wants to merge 1 commit into
codex/sensorbox-refactor-28-phone-advanced-layoutsfrom
codex/sensorbox-refactor-29-phone-shell-layouts

Conversation

@Foxpace

@FoxpaceFoxpace commented Aug 15, 2026

Copy link
Copy Markdown
Owner

Completes the phone View cleanup by removing shell, onboarding, preference, and landscape XML layouts.

What was added

  • Removal of activity shell, app bar, navigation header, and content layouts.
  • Removal of privacy, storage, battery, power-saver, and preference layouts.
  • Removal of duplicated landscape variants and the API-specific preference screen.

How it works

The root Compose app now owns navigation and responsive layout. Composables adapt to available constraints and render onboarding and settings from state, so separate portrait, landscape, and API-version XML hierarchies are unnecessary.

Stack position

Layer 29 of 31 in the SensorBox refactor stack. Review this PR against its configured base to see only this layer.

Validation

  • Full stack: ./gradlew test — BUILD SUCCESSFUL (160 tasks)

@FoxpaceFoxpace changed the title codex/sensorbox refactor 29 phone shell layoutsrefactor(app): remove legacy shell and onboarding layoutsAug 15, 2026
@Foxpace
Foxpace marked this pull request as ready for review August 15, 2026 21:51
@FoxpaceChatGPT Codex Connector

Copy link
Copy Markdown
OwnerAuthor

Superseded by #46, which targets master and shows the final current tree. Closing this stacked layer so review stays on the consolidated diff; this PR remains available as history.

@FoxpaceFoxpace closed this Aug 19, 2026
@FoxpaceChatGPT Codex Connector

Copy link
Copy Markdown
OwnerAuthor

Stack restored at the author's request. This PR is again part of the original 31-layer refactor chain. The architecture work continues as stacked PRs #47 through #54; consolidated PR #46 is superseded.

@FoxpaceFoxpace reopened this Aug 19, 2026
@FoxpaceFoxpace closed this Aug 23, 2026
@Foxpace
Foxpace deleted the codex/sensorbox-refactor-29-phone-shell-layouts branch August 23, 2026 12:58
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Foxpace