Skip to content

Fix #99 where can't get API results with more than one page - #101

Open
seb26 wants to merge 1 commit into
Frameio:developfrom
seb26:issue99
Open

Fix #99 where can't get API results with more than one page#101
seb26 wants to merge 1 commit into
Frameio:developfrom
seb26:issue99

Conversation

@seb26

Copy link
Copy Markdown

Description:

Fix#99 which is when calling .get_children() and getting more than 50 results and therefore 2nd page and onwards, the frameioclient will send a request with bad URL encoded characters and containing no page number.

 File "/Users/seb/Development/frameio_dev/python-frameio-client/frameioclient/lib/utils.py", line 234, in __next__
self.method, self.endpoint, self.payload, self.current_page
File "/Users/seb/Development/frameio_dev/python-frameio-client/frameioclient/lib/transport.py", line 154, in get_specific_page
return self._api_call(method, endpoint)
File "/Users/seb/Development/frameio_dev/python-frameio-client/frameioclient/lib/transport.py", line 138, in _api_call
return r.raise_for_status()
File "/Users/seb/Development/frameio_dev/venv/lib/python3.7/site-packages/requests/models.py", line 1021, in raise_for_status
raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://api.frame.io/v2%7Bendpoint%7D?page=%7Bpage%7D

Depends on:

  • Does this PR depend on any other ones? no

Includes changes from:

  • Does this PR includ changes from another PR? no

I'd like feedback on:

  • What would you like feedback on?

@seb26seb26 changed the title fix https://github.com/Frameio/python-frameio-client/issues/99Fix #99 where can't get API results with more than one pageFeb 19, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

String is not formatted

1 participant

@seb26