Uh oh!
There was an error while loading. Please reload this page.
[DEVREL-484] Add support for Watermark ID downloads - #60
Merged
Conversation
jhodges10
requested review from
Jmeggesto, billyshambrook, jaypadia-frame and subsetpark
as code ownersAugust 25, 2020 19:48
jhodges10force-pushed
the
jh/watermark-id-downloads
branch
from
August 25, 2020 19:51
9f5c13d to
59e23ffComparejhodges10
commented
Aug 31, 2020
ContributorAuthor
I kind of want to put some test cases in here to cover this, unfortunately that's a bit messy given all of the upstream requirements for testing the different cases. @davtran Do you have any ideas here? |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEVREL-484
This should cover most cases for Watermark ID downloads.
There's a follow-on update for after this that overhauls downloads even more.