Skip to content

feat(Utils): Add signature verification utility function - #81

Open
jhodges10 wants to merge 3 commits into
developfrom
jh/add-signature-verification-util
Open

feat(Utils): Add signature verification utility function#81
jhodges10 wants to merge 3 commits into
developfrom
jh/add-signature-verification-util

Conversation

@jhodges10

@jhodges10jhodges10 commented Jun 20, 2021

Copy link
Copy Markdown
Contributor

DEVREL-558

What I'm doing

  • Adding signature verification util for custom actions/webhooks

Tests

  • Need to add test for this function

@jhodges10jhodges10 changed the title Add signature verification utilWIP Add signature verification utilJun 20, 2021
@jhodges10jhodges10 added the enhancement New feature or request label Jun 20, 2021
@jhodges10
jhodges10 requested a review from lezoudaliJuly 7, 2021 09:18
@jhodges10
jhodges10force-pushed the jh/add-signature-verification-util branch from 4d883c6 to a74dbfdCompareJuly 30, 2021 04:18
@jhodges10jhodges10 changed the title WIP Add signature verification utilfeat(Utils): Add signature verification utility functionAug 3, 2021
@jhodges10jhodges10 mentioned this pull request Aug 3, 2021
Comment threadframeioclient/lib/utils.py Outdated

@lezoudalilezoudali left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. as long as you've tested and it works as expected. I'd add some tests? 🤔

Co-authored-by: Lezou Dali <lezou.dali@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jhodges10@lezoudali