Uh oh!
There was an error while loading. Please reload this page.
Allow decoding of SMBIOS Type 11 serialnumbers - #55
Draft
JohnAZoidberg wants to merge 2 commits into
Draft
Conversation
JohnAZoidbergforce-pushed
the
smbios11-serialnums
branch
from
October 21, 2024 06:03
5fc3f51 to
7dd55b1CompareJohnAZoidbergforce-pushed
the
smbios11-serialnums
branch
from
April 27, 2025 07:03
7dd55b1 to
588d216CompareJohnAZoidbergforce-pushed
the
smbios11-serialnums
branch
from
June 2, 2025 16:42
588d216 to
d378c02Comparekiram9
commented
Jun 6, 2025
Member
cfg0 will struggle with keyboard which also use 'B' for some languages |
amstan
reviewed
Jun 6, 2025
| pub fn dump_oem_strings(strings: &SMBiosStringSet) { | ||
| for (i, s) in strings.into_iter().enumerate() { | ||
| let idx = i + 1; | ||
| let sn = match idx { |
There was a problem hiding this comment.
It would be cooler if you didn't use idx positions for decoding the serial number (remember what happened last time these positions changed?). Just put them in a big array, shuffle them, and try to tell what each of them is based on the serial number contents.
MemberAuthor
There was a problem hiding this comment.
The order doesn't change, the factory also depends on it, as far as I remember.
Decoding the serialnumber is harder as we would have to embed all possible serialnumbers and I couldn't include those for unannounced projects.
JohnAZoidbergforce-pushed
the
smbios11-serialnums
branch
from
June 6, 2025 05:51
d378c02 to
35f0d76CompareJohnAZoidbergforce-pushed
the
smbios11-serialnums
branch
from
October 22, 2025 00:43
35f0d76 to
630eec7CompareJohnAZoidbergforce-pushed
the
smbios11-serialnums
branch
2 times, most recently
from
January 18, 2026 07:43
7f595f8 to
7630f51CompareJohnAZoidbergforce-pushed
the
smbios11-serialnums
branch
from
March 8, 2026 17:10
7630f51 to
7f09d4dCompareThey're the serialnumbers of what the system was originally assembled with in the factory. TODO - [ ] Cleanup code - [ ] Make safer with fewer unwraps - [ ] Custom command, not in info - [ ] Make sure date is decoded correctly - [ ] Support Framework 12 - [x] Support Framework 13 - [ ] Support Framework 16 Signed-off-by: Daniel Schaefer <dhs@frame.work>
Signed-off-by: Daniel Schaefer <dhs@frame.work>
JohnAZoidbergforce-pushed
the
smbios11-serialnums
branch
from
March 8, 2026 17:38
7f09d4d to
ee4c223Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They're the serialnumbers of what the system was originally assembled with in the factory.
TODO