spec: foundation-testing-ci track - Testing + CI/CD + Comparison + Sharing - #2
Merged
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Testing suite: Vitest + RTL, 80% inference coverage target - CI/CD: GitHub Actions, Husky pre-commit hooks - Comparison view: side-by-side laptop comparison - Shareable links: URL-encoded results + WhatsApp sharing - Plan, risks, tasks, acceptance criteria documented
…rage) - Install vitest, RTL, jsdom - Create vitest.config.js with jsdom environment - 34 convertToSpecs tests: gaming, creation, macOS, ChromeOS, budget, edge cases - 22 matchLaptopClass tests: GPU/OS/budget filtering, scoring, sorting - Fix normalize() regex stripping M1/M2/M3/M4 from Apple Silicon - Add gamesType scoring (complex +3 gfx, simple +1) - Add photoVideo:basic scoring (+1 gfx, +1 storage) - Add missing flags: prioritizeGaming, prioritizeScreenQuality - Coverage: 92% statements, 88% branches, 100% functions
- 16 new component tests (72 total) - LaptopCard: rendering, props, link, null handling - Recommendation: quiz flow, navigation, results, reset - Mock convertToSpecs for deterministic test results - Coverage: 90% statements, 85% branches, 86% functions - Document missing image fallback feature
- Create .github/workflows/ci.yml: lint → test → build - Node 22.x with npm caching - Triggers on push/PR to main - Add CI status badge to README.md - Update README with testing section and coverage stats
- Install husky and lint-staged
- Configure lint-staged for src/**/*.{js,jsx}
- Pre-commit hook runs eslint --fix on staged files
- Fix unused imports in LaptopCard.test.jsx
- Run eslint --fix on entire codebase to clean violations- Comparison component: side-by-side laptop comparison - Compare checkboxes on each laptop card (2-3 selection) - Sticky compare bar with laptop count - Spec comparison with better/worse highlighting - Shareable links: encode/decode results in URL - Copy link button with clipboard API - WhatsApp share button with pre-filled message - URL param decoding on mount to restore results - Responsive CSS for mobile comparison view
FranGuhforce-pushed
the
track/foundation-testing-ci
branch
from
May 10, 2026 02:13
ecf5706 to
2875bd5CompareUh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Track: Foundation — Testing + CI/CD + Comparison + Sharing
✅ All 7 phases complete
🔧 What was rebased/resolved
main(includes SEO/UI fixes from PR feat: SEO, UI polish, inference fixes, laptop DB update #1)✅ Verification
📱 Nuevas features visibles
Comparar laptops:
Compartir resultados:
Listo para review y merge.