Skip to content

[1.0.0] Security related fixes: value add / delete and sort keys. - #322

Merged
ChadSikorra merged 2 commits into
FreeDSx:mainfrom
ChadSikorra:fix/security-related
Sep 14, 2026
Merged

ChadSikorra merged 2 commits into
FreeDSx:mainfrom
ChadSikorra:fix/security-related

Conversation

@ChadSikorra

Copy link
Copy Markdown
Contributor

Two things that need to be addressed:

  1. Sort keys for searches escaped the ACL check. They are now stripped / withheld in the same way as the other attributes. The ramifications to this is sorting by something like userPassword in specific directions (asc / desc) along with accounts you actually know the passwords of.
  2. A value add / delete on a modify leaks information when you have deny read but are allowed write. The obvious issue with this is one of the most common setups for userPassword. It gives someone with password reset abilities a way to basically guess existing passwords via result codes, as LDAP specifies a result code when a value already exists or does not exist. In the case of a deny read but allowed write, we now unconditionally return insufficientAccessRights for add / delete on everything that is not self. A replace is still allowed and is the recommended approach in this case for attributes you need that sort of ACL configuration on.

@ChadSikorra
ChadSikorra merged commit 28ecdb2 into FreeDSx:main Sep 14, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant