[1.0.0] Security related fixes: value add / delete and sort keys. - #322
Merged
Merged
Conversation
ChadSikorra
force-pushed
the
fix/security-related
branch
from
September 14, 2026 11:48
a7cf1ff to
9b31dd8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things that need to be addressed:
userPasswordin specific directions (asc / desc) along with accounts you actually know the passwords of.userPassword. It gives someone with password reset abilities a way to basically guess existing passwords via result codes, as LDAP specifies a result code when a value already exists or does not exist. In the case of a deny read but allowed write, we now unconditionally returninsufficientAccessRightsfor add / delete on everything that is notself. A replace is still allowed and is the recommended approach in this case for attributes you need that sort of ACL configuration on.