[1.0.0] More sane handling of large multi-value attributes - #323
Open
ChadSikorra wants to merge 3 commits into
Open
ChadSikorra wants to merge 3 commits into
ChadSikorra wants to merge 3 commits into
Conversation
… only between values that could possibly be equal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes some performance issues with large multi-value attributes. It's still not the best. And I think what we need is to split off multivalue dn relations into a separate table altogether. It's really the only way to tackle something like group membership at scale. Trying to store the entry as one blob is just not scalable for something like that. And we probably need limits in general on how many should be allowed in one attribute. This will have a follow up.