Skip to content

Update dbug functionality utility.functions.php - #196

Open
jfinstrom wants to merge 3 commits into
FreePBX:release/17.0from
jfinstrom:improvement/debug_logger
Open

Update dbug functionality utility.functions.php#196
jfinstrom wants to merge 3 commits into
FreePBX:release/17.0from
jfinstrom:improvement/debug_logger

Conversation

@jfinstrom

Copy link
Copy Markdown
Contributor

Resolves #791: The function was already using monolog but it wasn't utilizing the strengths of the tool.
This caused a lot of noise and extra junk added to the dbug file.

Resolves #791: The function was already using monolog but it wasn't utilizing the strengths of the tool This caused a lot of noise and extra junk added to the fole.
CopilotAI review requested due to automatic review settings June 28, 2025 23:04

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the debug logging functionality by refactoring the old dbug() function to utilize Monolog’s advanced logging features and improve log output formatting. Key changes include adding typed function signatures and new helper functions, integrating sensitive data masking in log messages, and replacing the old dbug_write implementation.

Comment threadamp_conf/htdocs/admin/libraries/utility.functions.php Outdated
Comment threadamp_conf/htdocs/admin/libraries/utility.functions.php Outdated
jfinstromand others added 2 commits July 10, 2025 14:11
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@miken32

Copy link
Copy Markdown
Contributor

IMO it would make more sense to put stuff into a utility class rather than add a half dozen more functions to the global namespace. Also I'm not seeing that "sensitive data" formatter used anywhere in the PR.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jfinstrom@miken32