Uh oh!
There was an error while loading. Please reload this page.
Improve readability by removing #defined strings - #135
Conversation
7407689 to
d834a62Compare
kstribrnAmzn
left a comment
There was a problem hiding this comment.
I'm just going to state my opinion here which I realize is different from many on our team for the record....
In general, I'm a fan of removing single character and one use macros. I'm not really a fan of removing multi-character, multi-use macros. I'm okay with removing length macros as long as there is context where the raw value is used.
Essentially I think the macro name gives context more than anything, and I don't want to lose this context as it may result in future new developers suffering a harsher learning curve.
/stepping-of-my-soap-box
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
e82a892 to
b5f5963Compareb5f5963 to
99b236bCompare
Remove macro-defined string constants that are used in a limited number of places or are obvious.