Fix pinned go-judge downloads in algorithmic Dockerfile - #189
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The changes are fully reviewed with no unresolved blocking issues.
Pull request overview
Updates the algorithmic Dockerfile to install the pinned go-judge release reliably.
Changes:
- Uses versioned
amd64v2andarm64assets. - Removes the latest-release fallback.
- Verifies checksums before extraction.
File summaries
| File | Description |
|---|---|
algorithmic/Dockerfile |
Updates go-judge download, checksum validation, and extraction logic. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
Hi @hhh2210, I checked with @YanagiOrigami. This fix looks good to us, though the old version will not hurt. Just merged. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The algorithmic Dockerfile requests
go-judge_linux_<arch>.tar.gz, which does not match the assets published for the pinnedv1.11.1release. Its fallback queriesreleases/latest, so a successful fallback can silently install a different version.This change:
amd64v2/arm64architecture names;checksums.txtbefore extraction, and fails if the download or checksum is missing/invalid.The change is limited to the go-judge installation step.
Type of Change
Testing
/bin/truewith statusAccepted.git diff --checkpassed.Full-image build limitation: both the unchanged base and this branch fail at the earlier
RUN npm install -g npm@lateststep withnpm: not foundin the local cached build environment. Neither reaches the modified go-judge step. The tests above validate the changed installer and ARM64 runtime; they are not a claim that the complete image build passed or that x86-64 runtime execution was tested.Checklist