Uh oh!
There was an error while loading. Please reload this page.
Validation Updates - #363
Conversation
If marked as mandatory in format, throw error.
Covered by import from formats list.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| validate(prop) | ||
| for err in validate(prop).errors: | ||
| assert("error" not in err.rank) |
There was a problem hiding this comment.
Some tests with invalid objects that check if the correct errors are produced should also be added.
More useful would be to test the new functionality. This PR introduces validation on object creation, so the new functionality should be tested: Are the appropriate error messages printed when an object with issues is created? Since we just print the errors to stdout when this happens and the errors aren't stored anywhere after that, it might be necessary to capture stdout in the tests and check if the expected output was printed.
Uh oh!
There was an error while loading. Please reload this page.
Checks for Code Quality:
|
mpsonntag
left a comment
There was a problem hiding this comment.
Looks good, thanks! One additional small change and one comment (WARNING->ERROR) has not been resolved yet.
Uh oh!
There was an error while loading. Please reload this page.
fschrader1992
commented
Mar 18, 2020
Checks for Code Quality:
|
achilleas-k
commented
Mar 18, 2020
Approved from me, though I'd like to see a few more tests for the validation. Will open an issue as follow-up to this. |
This PR