fix(worktree): normalize Windows managed paths - #2254
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
\\?\C:\...form to the compatible drive-letter form before constructing the Git target//?/...Fixes#2249
Root cause
tokio::fs::canonicalizereturns a verbatim path on Windows. The managed-worktree flow then normalized backslashes for the Git CLI, turning\\?\C:\...into//?/C:/...; Git for Windows rejected that target while creating the linked worktree.gitfile.Verification
cargo test -p bitfun-core --no-default-features --features agent-runtime,git --lib service::worktree::tests::(22 passed on macOS)pnpm run check:repo-hygienegit diff --checkx86_64-pc-windows-msvccheck; the host lacks the MSVC C headers required bylibsqlite3-sys/libz-sys, so native Windows CI owns that platform runManaged worktrees remain explicitly unsupported for remote workspaces, so this change was exercised only in the local-workspace path.
AI assistance
AI-assisted; locally tested as listed above, with the Windows-specific regression delegated to the native CI matrix.