Uh oh!
There was an error while loading. Please reload this page.
Switch to using markdown - #5
Merged
Merged
Conversation
gregcorbett
requested review from
a user, RoseECooper, pjcon and tofu-rocketryFebruary 14, 2022 17:17
ghost
approved these changes
Feb 15, 2022
Uh oh!
There was an error while loading. Please reload this page.
ghost
approved these changes
Feb 28, 2022
gregcorbett
commented
May 19, 2022
MemberAuthor
I'm going to try and fix the travis build in this PR, so putting it back to draft for now. |
gregcorbett
marked this pull request as draft
May 19, 2022 15:15
gregcorbettforce-pushed
the
markdown
branch
2 times, most recently
from
May 19, 2022 16:33
f1411c4 to
2cc94baComparegregcorbettforce-pushed
the
markdown
branch
3 times, most recently
from
July 14, 2022 15:00
3ddd17e to
8355cc0Compare- Update images used to match the those currently being prepared for use in the main codebase: - https://github.com/gregcorbett/gocdb/blob/2022_logo_update
- looks better Co-authored-by: ineilson <ian.neilson@stfc.ac.uk>
- allow img HTML tags becaus Github Flavoured Markdown does not support image resizing.
Co-authored-by: tofu-rocketry <tofu-rocketry@users.noreply.github.com>
gregcorbett
marked this pull request as ready for review
July 15, 2022 10:08
gregcorbett
commented
Jul 15, 2022
MemberAuthor
Or indeed, replace the travis build with GitHub actions 😄 |
gregcorbett
commented
Jul 15, 2022
MemberAuthor
The GitHub actions were successful: https://github.com/gregcorbett/GOCDB.github.io/actions/runs/2676140839, but I guess won't show up on a PR untill this PR is merged, |
tofu-rocketry
approved these changes
Aug 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves#4
This PR reworks the main page for GOCDB.github.io to use markdown instead of HTML, giving it a bit of an update at the same time.
It's viewable here: https://gregcorbett.github.io/GOCDB.github.io/