Adding changes to GpiiActivity.java class and AndroidManifest.xml from Gpii Android Application in order to allow its own installation

[Diegohp]

No description provided.

[javihernandez]

Every message needs to be in english

[javihernandez]

Beside my comments,

• This branch is completely out of date and it needs to be updated with the current master
• We do not use tabs for intents. Please, use 4-space intents

[javihernandez]

s/Cloud4all/GPII

[javihernandez]

Respect the headers

[javihernandez]

empty whitespaces

[javihernandez]

@Diegohp,
thanks for keep working on this. Although you addressed some of my comments I still see a lot of extra whitespaces, tabs, wrong indentation, etc. The point of these comments is to make the code more readable for everyone.

[javihernandez]

@Diegohp,

also, I would love to have most of the new added functions into a separate .java file (ie: utilities.java). I would like to keep the GpiiActivity.java file as cleaner (and readable) as possible.

[javihernandez]

missing dep

[javihernandez]

Hi @Diegohp,

it's not building here, I'm getting the following results when trying to build it:

-compile:
[javac] Compiling 82 source files to /home/jhernandez/drafts/GPII-Android-Installer/android/platform/app/bin/classes
[javac] /home/jhernandez/drafts/GPII-Android-Installer/android/platform/app/src/net/gpii/app/GpiiActivity.java:28: error: package org.apache.commons.compress.archivers.tar does not exist
[javac] import org.apache.commons.compress.archivers.tar.TarArchiveEntry;
[javac] ^
[javac] /home/jhernandez/drafts/GPII-Android-Installer/android/platform/app/src/net/gpii/app/GpiiActivity.java:29: error: package org.apache.commons.compress.archivers.tar does not exist
[javac] import org.apache.commons.compress.archivers.tar.TarArchiveInputStream;
[javac] ^
[javac] /home/jhernandez/drafts/GPII-Android-Installer/android/platform/app/src/net/gpii/app/GpiiActivity.java:30: error: package org.apache.commons.compress.compressors.gzip does not exist
[javac] import org.apache.commons.compress.compressors.gzip.GzipCompressorInputStream;
[javac] ^
[javac] /home/jhernandez/drafts/GPII-Android-Installer/android/platform/app/src/net/gpii/app/GpiiActivity.java:181: error: cannot find symbol
[javac] action = intent.getAction();
[javac] ^
[javac] symbol: variable action
[javac] /home/jhernandez/drafts/GPII-Android-Installer/android/platform/app/src/net/gpii/app/GpiiActivity.java:182: error: cannot find symbol
[javac] if (DownloadManager.ACTION_DOWNLOAD_COMPLETE.equals(action)) {
[javac] ^
[javac] symbol: variable action
[javac] /home/jhernandez/drafts/GPII-Android-Installer/android/platform/app/src/net/gpii/app/GpiiActivity.java:196: error: cannot find symbol
[javac] } else if (action.equals(ACTION_GPII_UNZIP_COMPLETE)) {
[javac] ^
[javac] symbol: variable action
[javac] /home/jhernandez/drafts/GPII-Android-Installer/android/platform/app/src/net/gpii/app/GpiiActivity.java:425: error: cannot find symbol
[javac] TarArchiveInputStream tarIn = null;
[javac] ^
[javac] symbol: class TarArchiveInputStream
[javac] location: class GpiiActivity
[javac] /home/jhernandez/drafts/GPII-Android-Installer/android/platform/app/src/net/gpii/app/GpiiActivity.java:427: error: cannot find symbol
[javac] tarIn = new TarArchiveInputStream(new GzipCompressorInputStream(
[javac] ^
[javac] symbol: class TarArchiveInputStream
[javac] location: class GpiiActivity
[javac] /home/jhernandez/drafts/GPII-Android-Installer/android/platform/app/src/net/gpii/app/GpiiActivity.java:427: error: cannot find symbol
[javac] tarIn = new TarArchiveInputStream(new GzipCompressorInputStream(
[javac] ^
[javac] symbol: class GzipCompressorInputStream
[javac] location: class GpiiActivity
[javac] /home/jhernandez/drafts/GPII-Android-Installer/android/platform/app/src/net/gpii/app/GpiiActivity.java:430: error: cannot find symbol
[javac] TarArchiveEntry tarEntry = tarIn.getNextTarEntry();
[javac] ^
[javac] symbol: class TarArchiveEntry
[javac] location: class GpiiActivity
[javac] Note: /home/jhernandez/drafts/GPII-Android-Installer/android/platform/app/src/net/gpii/app/GpiiActivity.java uses unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.
[javac] 10 errors
BUILD FAILED

Here I see 2 problems:

• Missing dependencies: already commented on the relevant import lines
• The action variable is never defined

Can you please fix these problems?

[javihernandez]

In relation to the missing dependencies,

anode is already including an utility for dealing with tar files, isn't it enough for our purposes? Is it really needed to include a new one?

[Diegohp]

Added dependencies for Tar and Gzip

[javihernandez]

Added dependencies for Tar and Gzip

I meant including the libraries, not importing them in the source code again

[javihernandez]

Why aren't we using the apache's official download URL of this library?