refactor: corrigindo totem - ajustando middlewre by rbxyz · Pull Request #101 · GRHInvDev/elo

rbxyz · 2025-09-17T12:07:46Z

Summary by CodeRabbit

New Features
- No user-facing feature changes in this release.
Performance
- Reduced data fetched during authentication checks for lighter requests and marginally faster responses.
Bug Fixes
- Improved stability when admin page configuration is missing, preventing potential errors in admin filtering.
Refactor
- Consolidated administrative permission checks into shared infrastructure for consistency.
- Simplified middleware logic without changing behavior.
Documentation
- Added clarifying comments around authentication and admin procedures.

vercel · 2025-09-17T12:07:50Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
elo	Building	Preview	Comment	Sep 17, 2025 0:07am

coderabbitai · 2025-09-17T12:07:52Z

Caution

Review failed

The pull request is closed.

Walkthrough

Refactors middleware formatting and comments. Centralizes admin guard by importing adminProcedure into the user router and removing its local guard. Tightens a length check for admin pages. Adjusts protectedProcedure to select only user id. Adds comments in adminProcedure without changing behavior.

Changes

Cohort / File(s)	Summary
Middleware refactor `src/middleware.ts`	Replaced single-line conditional with block form; added inline comments. No behavior change; auth.protect() still applies only to non-public routes.
User router admin guard update `src/server/api/routers/user.ts`	Removed local admin guard middleware; now imports `adminProcedure` from `../trpc`. Hardened check to `(roleConfig?.admin_pages?.length ?? 0) > 0`. No public API changes.
tRPC procedures payload trim `src/server/api/trpc.ts`	`protectedProcedure` now selects only `id` for user existence checks. `adminProcedure` retains `role_config` but adds comments about minimizing fields; no functional change or signature change.

Sequence Diagram(s)

sequenceDiagram
autonumber
actor C as Client
participant R as tRPC Router (user)
participant P as protectedProcedure/adminProcedure
participant DB as Database
C->>R: Invoke user endpoint
alt Protected route
R->>P: protectedProcedure
P->>DB: select user { id }
DB-->>P: user exists?
alt Not found
P-->>R: throw UNAUTHORIZED
R-->>C: Error
else Found
P-->>R: proceed
R-->>C: Success
end
else Admin route
R->>P: adminProcedure
P->>DB: select user { id, role_config }
DB-->>P: user + role_config
P->>P: verify admin (unchanged logic)
alt Not admin
P-->>R: throw FORBIDDEN
R-->>C: Error
else Admin
P-->>R: proceed
R-->>C: Success
end
end

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

feat: modificando para que o Totem consiga ser acessado #97 — Also modifies tRPC protection and the user router, including adjustments to protectedProcedure selects and src/server/api/routers/user.ts logic.

Poem

A nibble of code, a hop through the gate,
Guards moved to the burrow—centralized fate.
IDs travel light, less baggage to bring,
Admins verified with a whisker’s swing.
With carrot-shaped commas and orderly trails,
This patch thumps softly—no broken tails. 🥕🐇

✨ Finishing touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch 100-correcao-totem

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2331795 and b79fd61.

📒 Files selected for processing (3)

src/middleware.ts (1 hunks)
src/server/api/routers/user.ts (2 hunks)
src/server/api/trpc.ts (2 hunks)

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"mode: "warning"instructions: | Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

rbxyz · 2025-09-17T12:07:46Z

Summary by CodeRabbit

New Features
- No user-facing feature changes in this release.
Performance
- Reduced data fetched during authentication checks for lighter requests and marginally faster responses.
Bug Fixes
- Improved stability when admin page configuration is missing, preventing potential errors in admin filtering.
Refactor
- Consolidated administrative permission checks into shared infrastructure for consistency.
- Simplified middleware logic without changing behavior.
Documentation
- Added clarifying comments around authentication and admin procedures.

vercel · 2025-09-17T12:07:50Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
elo	Building	Preview	Comment	Sep 17, 2025 0:07am

coderabbitai · 2025-09-17T12:07:52Z

Caution

Review failed

The pull request is closed.

Walkthrough

Refactors middleware formatting and comments. Centralizes admin guard by importing adminProcedure into the user router and removing its local guard. Tightens a length check for admin pages. Adjusts protectedProcedure to select only user id. Adds comments in adminProcedure without changing behavior.

Changes

Cohort / File(s)	Summary
Middleware refactor `src/middleware.ts`	Replaced single-line conditional with block form; added inline comments. No behavior change; auth.protect() still applies only to non-public routes.
User router admin guard update `src/server/api/routers/user.ts`	Removed local admin guard middleware; now imports `adminProcedure` from `../trpc`. Hardened check to `(roleConfig?.admin_pages?.length ?? 0) > 0`. No public API changes.
tRPC procedures payload trim `src/server/api/trpc.ts`	`protectedProcedure` now selects only `id` for user existence checks. `adminProcedure` retains `role_config` but adds comments about minimizing fields; no functional change or signature change.

Sequence Diagram(s)

sequenceDiagram
autonumber
actor C as Client
participant R as tRPC Router (user)
participant P as protectedProcedure/adminProcedure
participant DB as Database
C->>R: Invoke user endpoint
alt Protected route
R->>P: protectedProcedure
P->>DB: select user { id }
DB-->>P: user exists?
alt Not found
P-->>R: throw UNAUTHORIZED
R-->>C: Error
else Found
P-->>R: proceed
R-->>C: Success
end
else Admin route
R->>P: adminProcedure
P->>DB: select user { id, role_config }
DB-->>P: user + role_config
P->>P: verify admin (unchanged logic)
alt Not admin
P-->>R: throw FORBIDDEN
R-->>C: Error
else Admin
P-->>R: proceed
R-->>C: Success
end
end

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

feat: modificando para que o Totem consiga ser acessado #97 — Also modifies tRPC protection and the user router, including adjustments to protectedProcedure selects and src/server/api/routers/user.ts logic.

Poem

A nibble of code, a hop through the gate,
Guards moved to the burrow—centralized fate.
IDs travel light, less baggage to bring,
Admins verified with a whisker’s swing.
With carrot-shaped commas and orderly trails,
This patch thumps softly—no broken tails. 🥕🐇

✨ Finishing touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch 100-correcao-totem

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2331795 and b79fd61.

📒 Files selected for processing (3)

src/middleware.ts (1 hunks)
src/server/api/routers/user.ts (2 hunks)
src/server/api/trpc.ts (2 hunks)

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"mode: "warning"instructions: | Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

rbxyz · 2025-09-17T12:07:46Z

Summary by CodeRabbit

New Features
- No user-facing feature changes in this release.
Performance
- Reduced data fetched during authentication checks for lighter requests and marginally faster responses.
Bug Fixes
- Improved stability when admin page configuration is missing, preventing potential errors in admin filtering.
Refactor
- Consolidated administrative permission checks into shared infrastructure for consistency.
- Simplified middleware logic without changing behavior.
Documentation
- Added clarifying comments around authentication and admin procedures.

vercel · 2025-09-17T12:07:50Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
elo	Building	Preview	Comment	Sep 17, 2025 0:07am

coderabbitai · 2025-09-17T12:07:52Z

Caution

Review failed

The pull request is closed.

Walkthrough

Refactors middleware formatting and comments. Centralizes admin guard by importing adminProcedure into the user router and removing its local guard. Tightens a length check for admin pages. Adjusts protectedProcedure to select only user id. Adds comments in adminProcedure without changing behavior.

Changes

Cohort / File(s)	Summary
Middleware refactor `src/middleware.ts`	Replaced single-line conditional with block form; added inline comments. No behavior change; auth.protect() still applies only to non-public routes.
User router admin guard update `src/server/api/routers/user.ts`	Removed local admin guard middleware; now imports `adminProcedure` from `../trpc`. Hardened check to `(roleConfig?.admin_pages?.length ?? 0) > 0`. No public API changes.
tRPC procedures payload trim `src/server/api/trpc.ts`	`protectedProcedure` now selects only `id` for user existence checks. `adminProcedure` retains `role_config` but adds comments about minimizing fields; no functional change or signature change.

Sequence Diagram(s)

sequenceDiagram
autonumber
actor C as Client
participant R as tRPC Router (user)
participant P as protectedProcedure/adminProcedure
participant DB as Database
C->>R: Invoke user endpoint
alt Protected route
R->>P: protectedProcedure
P->>DB: select user { id }
DB-->>P: user exists?
alt Not found
P-->>R: throw UNAUTHORIZED
R-->>C: Error
else Found
P-->>R: proceed
R-->>C: Success
end
else Admin route
R->>P: adminProcedure
P->>DB: select user { id, role_config }
DB-->>P: user + role_config
P->>P: verify admin (unchanged logic)
alt Not admin
P-->>R: throw FORBIDDEN
R-->>C: Error
else Admin
P-->>R: proceed
R-->>C: Success
end
end

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

feat: modificando para que o Totem consiga ser acessado #97 — Also modifies tRPC protection and the user router, including adjustments to protectedProcedure selects and src/server/api/routers/user.ts logic.

Poem

A nibble of code, a hop through the gate,
Guards moved to the burrow—centralized fate.
IDs travel light, less baggage to bring,
Admins verified with a whisker’s swing.
With carrot-shaped commas and orderly trails,
This patch thumps softly—no broken tails. 🥕🐇

✨ Finishing touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch 100-correcao-totem

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2331795 and b79fd61.

📒 Files selected for processing (3)

src/middleware.ts (1 hunks)
src/server/api/routers/user.ts (2 hunks)
src/server/api/trpc.ts (2 hunks)

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"mode: "warning"instructions: | Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

rbxyz · 2025-09-17T12:07:46Z

Summary by CodeRabbit

New Features
- No user-facing feature changes in this release.
Performance
- Reduced data fetched during authentication checks for lighter requests and marginally faster responses.
Bug Fixes
- Improved stability when admin page configuration is missing, preventing potential errors in admin filtering.
Refactor
- Consolidated administrative permission checks into shared infrastructure for consistency.
- Simplified middleware logic without changing behavior.
Documentation
- Added clarifying comments around authentication and admin procedures.

vercel · 2025-09-17T12:07:50Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
elo	Building	Preview	Comment	Sep 17, 2025 0:07am

coderabbitai · 2025-09-17T12:07:52Z

Caution

Review failed

The pull request is closed.

Walkthrough

Refactors middleware formatting and comments. Centralizes admin guard by importing adminProcedure into the user router and removing its local guard. Tightens a length check for admin pages. Adjusts protectedProcedure to select only user id. Adds comments in adminProcedure without changing behavior.

Changes

Cohort / File(s)	Summary
Middleware refactor `src/middleware.ts`	Replaced single-line conditional with block form; added inline comments. No behavior change; auth.protect() still applies only to non-public routes.
User router admin guard update `src/server/api/routers/user.ts`	Removed local admin guard middleware; now imports `adminProcedure` from `../trpc`. Hardened check to `(roleConfig?.admin_pages?.length ?? 0) > 0`. No public API changes.
tRPC procedures payload trim `src/server/api/trpc.ts`	`protectedProcedure` now selects only `id` for user existence checks. `adminProcedure` retains `role_config` but adds comments about minimizing fields; no functional change or signature change.

Sequence Diagram(s)

sequenceDiagram
autonumber
actor C as Client
participant R as tRPC Router (user)
participant P as protectedProcedure/adminProcedure
participant DB as Database
C->>R: Invoke user endpoint
alt Protected route
R->>P: protectedProcedure
P->>DB: select user { id }
DB-->>P: user exists?
alt Not found
P-->>R: throw UNAUTHORIZED
R-->>C: Error
else Found
P-->>R: proceed
R-->>C: Success
end
else Admin route
R->>P: adminProcedure
P->>DB: select user { id, role_config }
DB-->>P: user + role_config
P->>P: verify admin (unchanged logic)
alt Not admin
P-->>R: throw FORBIDDEN
R-->>C: Error
else Admin
P-->>R: proceed
R-->>C: Success
end
end

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

feat: modificando para que o Totem consiga ser acessado #97 — Also modifies tRPC protection and the user router, including adjustments to protectedProcedure selects and src/server/api/routers/user.ts logic.

Poem

A nibble of code, a hop through the gate,
Guards moved to the burrow—centralized fate.
IDs travel light, less baggage to bring,
Admins verified with a whisker’s swing.
With carrot-shaped commas and orderly trails,
This patch thumps softly—no broken tails. 🥕🐇

✨ Finishing touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch 100-correcao-totem

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2331795 and b79fd61.

📒 Files selected for processing (3)

src/middleware.ts (1 hunks)
src/server/api/routers/user.ts (2 hunks)
src/server/api/trpc.ts (2 hunks)

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"mode: "warning"instructions: | Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

rbxyz · 2025-09-17T12:07:46Z

Summary by CodeRabbit

New Features
- No user-facing feature changes in this release.
Performance
- Reduced data fetched during authentication checks for lighter requests and marginally faster responses.
Bug Fixes
- Improved stability when admin page configuration is missing, preventing potential errors in admin filtering.
Refactor
- Consolidated administrative permission checks into shared infrastructure for consistency.
- Simplified middleware logic without changing behavior.
Documentation
- Added clarifying comments around authentication and admin procedures.

vercel · 2025-09-17T12:07:50Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
elo	Building	Preview	Comment	Sep 17, 2025 0:07am

coderabbitai · 2025-09-17T12:07:52Z

Caution

Review failed

The pull request is closed.

Walkthrough

Refactors middleware formatting and comments. Centralizes admin guard by importing adminProcedure into the user router and removing its local guard. Tightens a length check for admin pages. Adjusts protectedProcedure to select only user id. Adds comments in adminProcedure without changing behavior.

Changes

Cohort / File(s)	Summary
Middleware refactor `src/middleware.ts`	Replaced single-line conditional with block form; added inline comments. No behavior change; auth.protect() still applies only to non-public routes.
User router admin guard update `src/server/api/routers/user.ts`	Removed local admin guard middleware; now imports `adminProcedure` from `../trpc`. Hardened check to `(roleConfig?.admin_pages?.length ?? 0) > 0`. No public API changes.
tRPC procedures payload trim `src/server/api/trpc.ts`	`protectedProcedure` now selects only `id` for user existence checks. `adminProcedure` retains `role_config` but adds comments about minimizing fields; no functional change or signature change.

Sequence Diagram(s)

sequenceDiagram
autonumber
actor C as Client
participant R as tRPC Router (user)
participant P as protectedProcedure/adminProcedure
participant DB as Database
C->>R: Invoke user endpoint
alt Protected route
R->>P: protectedProcedure
P->>DB: select user { id }
DB-->>P: user exists?
alt Not found
P-->>R: throw UNAUTHORIZED
R-->>C: Error
else Found
P-->>R: proceed
R-->>C: Success
end
else Admin route
R->>P: adminProcedure
P->>DB: select user { id, role_config }
DB-->>P: user + role_config
P->>P: verify admin (unchanged logic)
alt Not admin
P-->>R: throw FORBIDDEN
R-->>C: Error
else Admin
P-->>R: proceed
R-->>C: Success
end
end

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

feat: modificando para que o Totem consiga ser acessado #97 — Also modifies tRPC protection and the user router, including adjustments to protectedProcedure selects and src/server/api/routers/user.ts logic.

Poem

A nibble of code, a hop through the gate,
Guards moved to the burrow—centralized fate.
IDs travel light, less baggage to bring,
Admins verified with a whisker’s swing.
With carrot-shaped commas and orderly trails,
This patch thumps softly—no broken tails. 🥕🐇

✨ Finishing touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch 100-correcao-totem

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2331795 and b79fd61.

📒 Files selected for processing (3)

src/middleware.ts (1 hunks)
src/server/api/routers/user.ts (2 hunks)
src/server/api/trpc.ts (2 hunks)

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"mode: "warning"instructions: | Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

rbxyz · 2025-09-17T12:07:46Z

Summary by CodeRabbit

New Features
- No user-facing feature changes in this release.
Performance
- Reduced data fetched during authentication checks for lighter requests and marginally faster responses.
Bug Fixes
- Improved stability when admin page configuration is missing, preventing potential errors in admin filtering.
Refactor
- Consolidated administrative permission checks into shared infrastructure for consistency.
- Simplified middleware logic without changing behavior.
Documentation
- Added clarifying comments around authentication and admin procedures.

vercel · 2025-09-17T12:07:50Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
elo	Building	Preview	Comment	Sep 17, 2025 0:07am

coderabbitai · 2025-09-17T12:07:52Z

Caution

Review failed

The pull request is closed.

Walkthrough

Refactors middleware formatting and comments. Centralizes admin guard by importing adminProcedure into the user router and removing its local guard. Tightens a length check for admin pages. Adjusts protectedProcedure to select only user id. Adds comments in adminProcedure without changing behavior.

Changes

Cohort / File(s)	Summary
Middleware refactor `src/middleware.ts`	Replaced single-line conditional with block form; added inline comments. No behavior change; auth.protect() still applies only to non-public routes.
User router admin guard update `src/server/api/routers/user.ts`	Removed local admin guard middleware; now imports `adminProcedure` from `../trpc`. Hardened check to `(roleConfig?.admin_pages?.length ?? 0) > 0`. No public API changes.
tRPC procedures payload trim `src/server/api/trpc.ts`	`protectedProcedure` now selects only `id` for user existence checks. `adminProcedure` retains `role_config` but adds comments about minimizing fields; no functional change or signature change.

Sequence Diagram(s)

sequenceDiagram
autonumber
actor C as Client
participant R as tRPC Router (user)
participant P as protectedProcedure/adminProcedure
participant DB as Database
C->>R: Invoke user endpoint
alt Protected route
R->>P: protectedProcedure
P->>DB: select user { id }
DB-->>P: user exists?
alt Not found
P-->>R: throw UNAUTHORIZED
R-->>C: Error
else Found
P-->>R: proceed
R-->>C: Success
end
else Admin route
R->>P: adminProcedure
P->>DB: select user { id, role_config }
DB-->>P: user + role_config
P->>P: verify admin (unchanged logic)
alt Not admin
P-->>R: throw FORBIDDEN
R-->>C: Error
else Admin
P-->>R: proceed
R-->>C: Success
end
end

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

feat: modificando para que o Totem consiga ser acessado #97 — Also modifies tRPC protection and the user router, including adjustments to protectedProcedure selects and src/server/api/routers/user.ts logic.

Poem

A nibble of code, a hop through the gate,
Guards moved to the burrow—centralized fate.
IDs travel light, less baggage to bring,
Admins verified with a whisker’s swing.
With carrot-shaped commas and orderly trails,
This patch thumps softly—no broken tails. 🥕🐇

✨ Finishing touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch 100-correcao-totem

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2331795 and b79fd61.

📒 Files selected for processing (3)

src/middleware.ts (1 hunks)
src/server/api/routers/user.ts (2 hunks)
src/server/api/trpc.ts (2 hunks)

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"mode: "warning"instructions: | Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

rbxyz · 2025-09-17T12:07:46Z

Summary by CodeRabbit

New Features
- No user-facing feature changes in this release.
Performance
- Reduced data fetched during authentication checks for lighter requests and marginally faster responses.
Bug Fixes
- Improved stability when admin page configuration is missing, preventing potential errors in admin filtering.
Refactor
- Consolidated administrative permission checks into shared infrastructure for consistency.
- Simplified middleware logic without changing behavior.
Documentation
- Added clarifying comments around authentication and admin procedures.

vercel · 2025-09-17T12:07:50Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
elo	Building	Preview	Comment	Sep 17, 2025 0:07am

coderabbitai · 2025-09-17T12:07:52Z

Caution

Review failed

The pull request is closed.

Walkthrough

Refactors middleware formatting and comments. Centralizes admin guard by importing adminProcedure into the user router and removing its local guard. Tightens a length check for admin pages. Adjusts protectedProcedure to select only user id. Adds comments in adminProcedure without changing behavior.

Changes

Cohort / File(s)	Summary
Middleware refactor `src/middleware.ts`	Replaced single-line conditional with block form; added inline comments. No behavior change; auth.protect() still applies only to non-public routes.
User router admin guard update `src/server/api/routers/user.ts`	Removed local admin guard middleware; now imports `adminProcedure` from `../trpc`. Hardened check to `(roleConfig?.admin_pages?.length ?? 0) > 0`. No public API changes.
tRPC procedures payload trim `src/server/api/trpc.ts`	`protectedProcedure` now selects only `id` for user existence checks. `adminProcedure` retains `role_config` but adds comments about minimizing fields; no functional change or signature change.

Sequence Diagram(s)

sequenceDiagram
autonumber
actor C as Client
participant R as tRPC Router (user)
participant P as protectedProcedure/adminProcedure
participant DB as Database
C->>R: Invoke user endpoint
alt Protected route
R->>P: protectedProcedure
P->>DB: select user { id }
DB-->>P: user exists?
alt Not found
P-->>R: throw UNAUTHORIZED
R-->>C: Error
else Found
P-->>R: proceed
R-->>C: Success
end
else Admin route
R->>P: adminProcedure
P->>DB: select user { id, role_config }
DB-->>P: user + role_config
P->>P: verify admin (unchanged logic)
alt Not admin
P-->>R: throw FORBIDDEN
R-->>C: Error
else Admin
P-->>R: proceed
R-->>C: Success
end
end

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

feat: modificando para que o Totem consiga ser acessado #97 — Also modifies tRPC protection and the user router, including adjustments to protectedProcedure selects and src/server/api/routers/user.ts logic.

Poem

A nibble of code, a hop through the gate,
Guards moved to the burrow—centralized fate.
IDs travel light, less baggage to bring,
Admins verified with a whisker’s swing.
With carrot-shaped commas and orderly trails,
This patch thumps softly—no broken tails. 🥕🐇

✨ Finishing touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch 100-correcao-totem

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2331795 and b79fd61.

📒 Files selected for processing (3)

src/middleware.ts (1 hunks)
src/server/api/routers/user.ts (2 hunks)
src/server/api/trpc.ts (2 hunks)

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"mode: "warning"instructions: | Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

rbxyz · 2025-09-17T12:07:46Z

Summary by CodeRabbit

New Features
- No user-facing feature changes in this release.
Performance
- Reduced data fetched during authentication checks for lighter requests and marginally faster responses.
Bug Fixes
- Improved stability when admin page configuration is missing, preventing potential errors in admin filtering.
Refactor
- Consolidated administrative permission checks into shared infrastructure for consistency.
- Simplified middleware logic without changing behavior.
Documentation
- Added clarifying comments around authentication and admin procedures.

vercel · 2025-09-17T12:07:50Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
elo	Building	Preview	Comment	Sep 17, 2025 0:07am

coderabbitai · 2025-09-17T12:07:52Z

Caution

Review failed

The pull request is closed.

Walkthrough

Refactors middleware formatting and comments. Centralizes admin guard by importing adminProcedure into the user router and removing its local guard. Tightens a length check for admin pages. Adjusts protectedProcedure to select only user id. Adds comments in adminProcedure without changing behavior.

Changes

Cohort / File(s)	Summary
Middleware refactor `src/middleware.ts`	Replaced single-line conditional with block form; added inline comments. No behavior change; auth.protect() still applies only to non-public routes.
User router admin guard update `src/server/api/routers/user.ts`	Removed local admin guard middleware; now imports `adminProcedure` from `../trpc`. Hardened check to `(roleConfig?.admin_pages?.length ?? 0) > 0`. No public API changes.
tRPC procedures payload trim `src/server/api/trpc.ts`	`protectedProcedure` now selects only `id` for user existence checks. `adminProcedure` retains `role_config` but adds comments about minimizing fields; no functional change or signature change.

Sequence Diagram(s)

sequenceDiagram
autonumber
actor C as Client
participant R as tRPC Router (user)
participant P as protectedProcedure/adminProcedure
participant DB as Database
C->>R: Invoke user endpoint
alt Protected route
R->>P: protectedProcedure
P->>DB: select user { id }
DB-->>P: user exists?
alt Not found
P-->>R: throw UNAUTHORIZED
R-->>C: Error
else Found
P-->>R: proceed
R-->>C: Success
end
else Admin route
R->>P: adminProcedure
P->>DB: select user { id, role_config }
DB-->>P: user + role_config
P->>P: verify admin (unchanged logic)
alt Not admin
P-->>R: throw FORBIDDEN
R-->>C: Error
else Admin
P-->>R: proceed
R-->>C: Success
end
end

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

feat: modificando para que o Totem consiga ser acessado #97 — Also modifies tRPC protection and the user router, including adjustments to protectedProcedure selects and src/server/api/routers/user.ts logic.

Poem

A nibble of code, a hop through the gate,
Guards moved to the burrow—centralized fate.
IDs travel light, less baggage to bring,
Admins verified with a whisker’s swing.
With carrot-shaped commas and orderly trails,
This patch thumps softly—no broken tails. 🥕🐇

✨ Finishing touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch 100-correcao-totem

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2331795 and b79fd61.

📒 Files selected for processing (3)

src/middleware.ts (1 hunks)
src/server/api/routers/user.ts (2 hunks)
src/server/api/trpc.ts (2 hunks)

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"mode: "warning"instructions: | Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

refactor: corrigindo totem - ajustando middlewre
b79fd61

rbxyz linked an issue Sep 17, 2025 that may be closed by this pull request
Correção Totem #100
Closed

rbxyz merged commit 58475d6 into mainSep 17, 2025
2 of 3 checks passed

vercelBotdeployed to Preview September 17, 2025 12:10 View deployment

rbxyz deleted the 100-correcao-totem branch September 19, 2025 14:46