feat: adicionando novo filtro em filtros avançados de chamados

[rbxyz]

Summary by CodeRabbit

Release Notes

• New Features

  • Added form-based filtering to Kanban board—filter tasks by specific forms
  • Collapsible advanced filters section for improved UI organization

• Improvements

  • Enhanced loading state with improved visual feedback in Kanban view

• Chores

  • Version bumped to 1.7.5

[vercel]

Deployment failed with the following error:

You don't have permission to create a Preview Deployment for this Vercel project: elo.

View Documentation: https://vercel.com/docs/accounts/team-members-and-roles

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR adds form-level filtering to the Kanban view with a collapsible advanced filters UI. It introduces form selection as a new filter dimension, implements the backend query procedures for fetching forms and filtering responses, enhances the loading UI, and updates the filter state to include formIds. Version bumped to 1.7.5.

Changes

Cohort / File(s)	Summary
Version package.json	Bumped version from 1.7.0 to 1.7.5.
Kanban UI & Filters src/app/(authenticated)/forms/kanban/_components/kanban-filters.tsx, src/app/(authenticated)/forms/kanban/page.tsx	Introduced collapsible UI for advanced filters with chevron toggle icons. Added formIds filter dimension with MultiSelect UI labeled "Formulário". Integrated forms data fetching via api.form.listForKanbanFilter.useQuery(). Updated loading and empty states with KanbanFilters controls and replaced Loader2 with KanbanSkeleton. Extended filter state initialization and clear logic to handle formIds.
Backend Filtering & Endpoints src/server/api/routers/form-response.ts, src/server/api/routers/forms.ts	Added optional formIds: string[] input to form-response list procedures to enable filtering by specific forms. Implemented where clause logic to apply form ID filter when provided. Added new listForKanbanFilter protected procedure to forms router returning form { id, title } for current user (as creator or owner), ordered by title.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Possibly related PRs

• feat: enhance form response filtering and loading states #209: Both PRs modify the same Kanban filters and form-response routing to extend filtering capabilities with formIds-based filtering logic.
• 31 adicionar filtros formularios #32: Both PRs add and integrate the KanbanSkeleton component into the Kanban view UI.

Poem

🐰 A form to filter, a collapsible way,
Where Kanban boards gleam in organizational display,
With checkboxes checked and data aligned,
The filters unfold, what results you'll find! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title accurately describes the main change: adding a new filter (formIds) to the advanced filters section of the Kanban board. The title is specific, concise, and clearly reflects the primary objective of the changeset.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch 331-feature-novo-filtro-para-solicitações

---

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments

src/app/(authenticated)/forms/kanban/_components/kanban-filters.tsx (2)

186-201: Formulário filter section is clean and conditionally rendered.

Conditionally rendering only when the user owns forms (formsData.length > 0) is a good UX choice. One minor nit: the formsData ?? [] fallback on line 194 is redundant since the outer guard on line 187 already ensures formsData is truthy.

Nitpick: remove redundant nullish coalescing

- options={(formsData ?? []).map((f) => ({ label: f.title ?? f.id, value: f.id }))}+ options={formsData.map((f) => ({ label: f.title ?? f.id, value: f.id }))}

---

46-56: Debounce effect has a stale closure risk with filters in the dependency array.

The filters object reference changes on every filter update (since state is spread with { ...filters, ... }), which resets the debounce timer on any filter change — not just the number input. This means changing e.g. a tag filter while typing a number will restart the 500ms timer. This is pre-existing behavior, but worth noting for a future improvement: consider extracting the number debounce into a separate hook or using only localNumber + a stable callback ref.

src/app/(authenticated)/forms/kanban/page.tsx (1)

169-172: Empty-state message correctly considers the new formIds filter.

The condition now accounts for filters.formIds.length > 0 to distinguish between "no results matching filters" and "no responses yet." Note that filters.hasResponse and filters.endDate and filters.priority are not checked here, but this is pre-existing behavior outside the scope of this PR.

For future consistency, consider consolidating the "has any active filter" check to reuse the hasActiveFilters logic from KanbanFiltersState (or the KanbanFilters component) rather than duplicating partial checks inline. This would prevent the two from drifting apart.

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[rbxyz]

Summary by CodeRabbit

Release Notes

• New Features

  • Added form-based filtering to Kanban board—filter tasks by specific forms
  • Collapsible advanced filters section for improved UI organization

• Improvements

  • Enhanced loading state with improved visual feedback in Kanban view

• Chores

  • Version bumped to 1.7.5

[vercel]

Deployment failed with the following error:

You don't have permission to create a Preview Deployment for this Vercel project: elo.

View Documentation: https://vercel.com/docs/accounts/team-members-and-roles

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR adds form-level filtering to the Kanban view with a collapsible advanced filters UI. It introduces form selection as a new filter dimension, implements the backend query procedures for fetching forms and filtering responses, enhances the loading UI, and updates the filter state to include formIds. Version bumped to 1.7.5.

Changes

Cohort / File(s)	Summary
Version package.json	Bumped version from 1.7.0 to 1.7.5.
Kanban UI & Filters src/app/(authenticated)/forms/kanban/_components/kanban-filters.tsx, src/app/(authenticated)/forms/kanban/page.tsx	Introduced collapsible UI for advanced filters with chevron toggle icons. Added formIds filter dimension with MultiSelect UI labeled "Formulário". Integrated forms data fetching via api.form.listForKanbanFilter.useQuery(). Updated loading and empty states with KanbanFilters controls and replaced Loader2 with KanbanSkeleton. Extended filter state initialization and clear logic to handle formIds.
Backend Filtering & Endpoints src/server/api/routers/form-response.ts, src/server/api/routers/forms.ts	Added optional formIds: string[] input to form-response list procedures to enable filtering by specific forms. Implemented where clause logic to apply form ID filter when provided. Added new listForKanbanFilter protected procedure to forms router returning form { id, title } for current user (as creator or owner), ordered by title.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Possibly related PRs

• feat: enhance form response filtering and loading states #209: Both PRs modify the same Kanban filters and form-response routing to extend filtering capabilities with formIds-based filtering logic.
• 31 adicionar filtros formularios #32: Both PRs add and integrate the KanbanSkeleton component into the Kanban view UI.

Poem

🐰 A form to filter, a collapsible way,
Where Kanban boards gleam in organizational display,
With checkboxes checked and data aligned,
The filters unfold, what results you'll find! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title accurately describes the main change: adding a new filter (formIds) to the advanced filters section of the Kanban board. The title is specific, concise, and clearly reflects the primary objective of the changeset.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch 331-feature-novo-filtro-para-solicitações

---

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments

src/app/(authenticated)/forms/kanban/_components/kanban-filters.tsx (2)

186-201: Formulário filter section is clean and conditionally rendered.

Conditionally rendering only when the user owns forms (formsData.length > 0) is a good UX choice. One minor nit: the formsData ?? [] fallback on line 194 is redundant since the outer guard on line 187 already ensures formsData is truthy.

Nitpick: remove redundant nullish coalescing

- options={(formsData ?? []).map((f) => ({ label: f.title ?? f.id, value: f.id }))}+ options={formsData.map((f) => ({ label: f.title ?? f.id, value: f.id }))}

---

46-56: Debounce effect has a stale closure risk with filters in the dependency array.

The filters object reference changes on every filter update (since state is spread with { ...filters, ... }), which resets the debounce timer on any filter change — not just the number input. This means changing e.g. a tag filter while typing a number will restart the 500ms timer. This is pre-existing behavior, but worth noting for a future improvement: consider extracting the number debounce into a separate hook or using only localNumber + a stable callback ref.

src/app/(authenticated)/forms/kanban/page.tsx (1)

169-172: Empty-state message correctly considers the new formIds filter.

The condition now accounts for filters.formIds.length > 0 to distinguish between "no results matching filters" and "no responses yet." Note that filters.hasResponse and filters.endDate and filters.priority are not checked here, but this is pre-existing behavior outside the scope of this PR.

For future consistency, consider consolidating the "has any active filter" check to reuse the hasActiveFilters logic from KanbanFiltersState (or the KanbanFilters component) rather than duplicating partial checks inline. This would prevent the two from drifting apart.

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[rbxyz]

Summary by CodeRabbit

Release Notes

• New Features

  • Added form-based filtering to Kanban board—filter tasks by specific forms
  • Collapsible advanced filters section for improved UI organization

• Improvements

  • Enhanced loading state with improved visual feedback in Kanban view

• Chores

  • Version bumped to 1.7.5

[vercel]

Deployment failed with the following error:

You don't have permission to create a Preview Deployment for this Vercel project: elo.

View Documentation: https://vercel.com/docs/accounts/team-members-and-roles

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR adds form-level filtering to the Kanban view with a collapsible advanced filters UI. It introduces form selection as a new filter dimension, implements the backend query procedures for fetching forms and filtering responses, enhances the loading UI, and updates the filter state to include formIds. Version bumped to 1.7.5.

Changes

Cohort / File(s)	Summary
Version package.json	Bumped version from 1.7.0 to 1.7.5.
Kanban UI & Filters src/app/(authenticated)/forms/kanban/_components/kanban-filters.tsx, src/app/(authenticated)/forms/kanban/page.tsx	Introduced collapsible UI for advanced filters with chevron toggle icons. Added formIds filter dimension with MultiSelect UI labeled "Formulário". Integrated forms data fetching via api.form.listForKanbanFilter.useQuery(). Updated loading and empty states with KanbanFilters controls and replaced Loader2 with KanbanSkeleton. Extended filter state initialization and clear logic to handle formIds.
Backend Filtering & Endpoints src/server/api/routers/form-response.ts, src/server/api/routers/forms.ts	Added optional formIds: string[] input to form-response list procedures to enable filtering by specific forms. Implemented where clause logic to apply form ID filter when provided. Added new listForKanbanFilter protected procedure to forms router returning form { id, title } for current user (as creator or owner), ordered by title.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Possibly related PRs

• feat: enhance form response filtering and loading states #209: Both PRs modify the same Kanban filters and form-response routing to extend filtering capabilities with formIds-based filtering logic.
• 31 adicionar filtros formularios #32: Both PRs add and integrate the KanbanSkeleton component into the Kanban view UI.

Poem

🐰 A form to filter, a collapsible way,
Where Kanban boards gleam in organizational display,
With checkboxes checked and data aligned,
The filters unfold, what results you'll find! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title accurately describes the main change: adding a new filter (formIds) to the advanced filters section of the Kanban board. The title is specific, concise, and clearly reflects the primary objective of the changeset.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch 331-feature-novo-filtro-para-solicitações

---

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments

src/app/(authenticated)/forms/kanban/_components/kanban-filters.tsx (2)

186-201: Formulário filter section is clean and conditionally rendered.

Conditionally rendering only when the user owns forms (formsData.length > 0) is a good UX choice. One minor nit: the formsData ?? [] fallback on line 194 is redundant since the outer guard on line 187 already ensures formsData is truthy.

Nitpick: remove redundant nullish coalescing

- options={(formsData ?? []).map((f) => ({ label: f.title ?? f.id, value: f.id }))}+ options={formsData.map((f) => ({ label: f.title ?? f.id, value: f.id }))}

---

46-56: Debounce effect has a stale closure risk with filters in the dependency array.

The filters object reference changes on every filter update (since state is spread with { ...filters, ... }), which resets the debounce timer on any filter change — not just the number input. This means changing e.g. a tag filter while typing a number will restart the 500ms timer. This is pre-existing behavior, but worth noting for a future improvement: consider extracting the number debounce into a separate hook or using only localNumber + a stable callback ref.

src/app/(authenticated)/forms/kanban/page.tsx (1)

169-172: Empty-state message correctly considers the new formIds filter.

The condition now accounts for filters.formIds.length > 0 to distinguish between "no results matching filters" and "no responses yet." Note that filters.hasResponse and filters.endDate and filters.priority are not checked here, but this is pre-existing behavior outside the scope of this PR.

For future consistency, consider consolidating the "has any active filter" check to reuse the hasActiveFilters logic from KanbanFiltersState (or the KanbanFilters component) rather than duplicating partial checks inline. This would prevent the two from drifting apart.

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[rbxyz]

Summary by CodeRabbit

Release Notes

• New Features

  • Added form-based filtering to Kanban board—filter tasks by specific forms
  • Collapsible advanced filters section for improved UI organization

• Improvements

  • Enhanced loading state with improved visual feedback in Kanban view

• Chores

  • Version bumped to 1.7.5

[vercel]

Deployment failed with the following error:

You don't have permission to create a Preview Deployment for this Vercel project: elo.

View Documentation: https://vercel.com/docs/accounts/team-members-and-roles

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR adds form-level filtering to the Kanban view with a collapsible advanced filters UI. It introduces form selection as a new filter dimension, implements the backend query procedures for fetching forms and filtering responses, enhances the loading UI, and updates the filter state to include formIds. Version bumped to 1.7.5.

Changes

Cohort / File(s)	Summary
Version package.json	Bumped version from 1.7.0 to 1.7.5.
Kanban UI & Filters src/app/(authenticated)/forms/kanban/_components/kanban-filters.tsx, src/app/(authenticated)/forms/kanban/page.tsx	Introduced collapsible UI for advanced filters with chevron toggle icons. Added formIds filter dimension with MultiSelect UI labeled "Formulário". Integrated forms data fetching via api.form.listForKanbanFilter.useQuery(). Updated loading and empty states with KanbanFilters controls and replaced Loader2 with KanbanSkeleton. Extended filter state initialization and clear logic to handle formIds.
Backend Filtering & Endpoints src/server/api/routers/form-response.ts, src/server/api/routers/forms.ts	Added optional formIds: string[] input to form-response list procedures to enable filtering by specific forms. Implemented where clause logic to apply form ID filter when provided. Added new listForKanbanFilter protected procedure to forms router returning form { id, title } for current user (as creator or owner), ordered by title.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Possibly related PRs

• feat: enhance form response filtering and loading states #209: Both PRs modify the same Kanban filters and form-response routing to extend filtering capabilities with formIds-based filtering logic.
• 31 adicionar filtros formularios #32: Both PRs add and integrate the KanbanSkeleton component into the Kanban view UI.

Poem

🐰 A form to filter, a collapsible way,
Where Kanban boards gleam in organizational display,
With checkboxes checked and data aligned,
The filters unfold, what results you'll find! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title accurately describes the main change: adding a new filter (formIds) to the advanced filters section of the Kanban board. The title is specific, concise, and clearly reflects the primary objective of the changeset.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch 331-feature-novo-filtro-para-solicitações

---

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments

src/app/(authenticated)/forms/kanban/_components/kanban-filters.tsx (2)

186-201: Formulário filter section is clean and conditionally rendered.

Conditionally rendering only when the user owns forms (formsData.length > 0) is a good UX choice. One minor nit: the formsData ?? [] fallback on line 194 is redundant since the outer guard on line 187 already ensures formsData is truthy.

Nitpick: remove redundant nullish coalescing

- options={(formsData ?? []).map((f) => ({ label: f.title ?? f.id, value: f.id }))}+ options={formsData.map((f) => ({ label: f.title ?? f.id, value: f.id }))}

---

46-56: Debounce effect has a stale closure risk with filters in the dependency array.

The filters object reference changes on every filter update (since state is spread with { ...filters, ... }), which resets the debounce timer on any filter change — not just the number input. This means changing e.g. a tag filter while typing a number will restart the 500ms timer. This is pre-existing behavior, but worth noting for a future improvement: consider extracting the number debounce into a separate hook or using only localNumber + a stable callback ref.

src/app/(authenticated)/forms/kanban/page.tsx (1)

169-172: Empty-state message correctly considers the new formIds filter.

The condition now accounts for filters.formIds.length > 0 to distinguish between "no results matching filters" and "no responses yet." Note that filters.hasResponse and filters.endDate and filters.priority are not checked here, but this is pre-existing behavior outside the scope of this PR.

For future consistency, consider consolidating the "has any active filter" check to reuse the hasActiveFilters logic from KanbanFiltersState (or the KanbanFilters component) rather than duplicating partial checks inline. This would prevent the two from drifting apart.

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[rbxyz]

Summary by CodeRabbit

Release Notes

• New Features

  • Added form-based filtering to Kanban board—filter tasks by specific forms
  • Collapsible advanced filters section for improved UI organization

• Improvements

  • Enhanced loading state with improved visual feedback in Kanban view

• Chores

  • Version bumped to 1.7.5

[vercel]

Deployment failed with the following error:

You don't have permission to create a Preview Deployment for this Vercel project: elo.

View Documentation: https://vercel.com/docs/accounts/team-members-and-roles

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR adds form-level filtering to the Kanban view with a collapsible advanced filters UI. It introduces form selection as a new filter dimension, implements the backend query procedures for fetching forms and filtering responses, enhances the loading UI, and updates the filter state to include formIds. Version bumped to 1.7.5.

Changes

Cohort / File(s)	Summary
Version package.json	Bumped version from 1.7.0 to 1.7.5.
Kanban UI & Filters src/app/(authenticated)/forms/kanban/_components/kanban-filters.tsx, src/app/(authenticated)/forms/kanban/page.tsx	Introduced collapsible UI for advanced filters with chevron toggle icons. Added formIds filter dimension with MultiSelect UI labeled "Formulário". Integrated forms data fetching via api.form.listForKanbanFilter.useQuery(). Updated loading and empty states with KanbanFilters controls and replaced Loader2 with KanbanSkeleton. Extended filter state initialization and clear logic to handle formIds.
Backend Filtering & Endpoints src/server/api/routers/form-response.ts, src/server/api/routers/forms.ts	Added optional formIds: string[] input to form-response list procedures to enable filtering by specific forms. Implemented where clause logic to apply form ID filter when provided. Added new listForKanbanFilter protected procedure to forms router returning form { id, title } for current user (as creator or owner), ordered by title.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Possibly related PRs

• feat: enhance form response filtering and loading states #209: Both PRs modify the same Kanban filters and form-response routing to extend filtering capabilities with formIds-based filtering logic.
• 31 adicionar filtros formularios #32: Both PRs add and integrate the KanbanSkeleton component into the Kanban view UI.

Poem

🐰 A form to filter, a collapsible way,
Where Kanban boards gleam in organizational display,
With checkboxes checked and data aligned,
The filters unfold, what results you'll find! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title accurately describes the main change: adding a new filter (formIds) to the advanced filters section of the Kanban board. The title is specific, concise, and clearly reflects the primary objective of the changeset.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch 331-feature-novo-filtro-para-solicitações

---

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments

src/app/(authenticated)/forms/kanban/_components/kanban-filters.tsx (2)

186-201: Formulário filter section is clean and conditionally rendered.

Conditionally rendering only when the user owns forms (formsData.length > 0) is a good UX choice. One minor nit: the formsData ?? [] fallback on line 194 is redundant since the outer guard on line 187 already ensures formsData is truthy.

Nitpick: remove redundant nullish coalescing

- options={(formsData ?? []).map((f) => ({ label: f.title ?? f.id, value: f.id }))}+ options={formsData.map((f) => ({ label: f.title ?? f.id, value: f.id }))}

---

46-56: Debounce effect has a stale closure risk with filters in the dependency array.

The filters object reference changes on every filter update (since state is spread with { ...filters, ... }), which resets the debounce timer on any filter change — not just the number input. This means changing e.g. a tag filter while typing a number will restart the 500ms timer. This is pre-existing behavior, but worth noting for a future improvement: consider extracting the number debounce into a separate hook or using only localNumber + a stable callback ref.

src/app/(authenticated)/forms/kanban/page.tsx (1)

169-172: Empty-state message correctly considers the new formIds filter.

The condition now accounts for filters.formIds.length > 0 to distinguish between "no results matching filters" and "no responses yet." Note that filters.hasResponse and filters.endDate and filters.priority are not checked here, but this is pre-existing behavior outside the scope of this PR.

For future consistency, consider consolidating the "has any active filter" check to reuse the hasActiveFilters logic from KanbanFiltersState (or the KanbanFilters component) rather than duplicating partial checks inline. This would prevent the two from drifting apart.

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[rbxyz]

Summary by CodeRabbit

Release Notes

• New Features

  • Added form-based filtering to Kanban board—filter tasks by specific forms
  • Collapsible advanced filters section for improved UI organization

• Improvements

  • Enhanced loading state with improved visual feedback in Kanban view

• Chores

  • Version bumped to 1.7.5

[vercel]

Deployment failed with the following error:

You don't have permission to create a Preview Deployment for this Vercel project: elo.

View Documentation: https://vercel.com/docs/accounts/team-members-and-roles

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR adds form-level filtering to the Kanban view with a collapsible advanced filters UI. It introduces form selection as a new filter dimension, implements the backend query procedures for fetching forms and filtering responses, enhances the loading UI, and updates the filter state to include formIds. Version bumped to 1.7.5.

Changes

Cohort / File(s)	Summary
Version package.json	Bumped version from 1.7.0 to 1.7.5.
Kanban UI & Filters src/app/(authenticated)/forms/kanban/_components/kanban-filters.tsx, src/app/(authenticated)/forms/kanban/page.tsx	Introduced collapsible UI for advanced filters with chevron toggle icons. Added formIds filter dimension with MultiSelect UI labeled "Formulário". Integrated forms data fetching via api.form.listForKanbanFilter.useQuery(). Updated loading and empty states with KanbanFilters controls and replaced Loader2 with KanbanSkeleton. Extended filter state initialization and clear logic to handle formIds.
Backend Filtering & Endpoints src/server/api/routers/form-response.ts, src/server/api/routers/forms.ts	Added optional formIds: string[] input to form-response list procedures to enable filtering by specific forms. Implemented where clause logic to apply form ID filter when provided. Added new listForKanbanFilter protected procedure to forms router returning form { id, title } for current user (as creator or owner), ordered by title.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Possibly related PRs

• feat: enhance form response filtering and loading states #209: Both PRs modify the same Kanban filters and form-response routing to extend filtering capabilities with formIds-based filtering logic.
• 31 adicionar filtros formularios #32: Both PRs add and integrate the KanbanSkeleton component into the Kanban view UI.

Poem

🐰 A form to filter, a collapsible way,
Where Kanban boards gleam in organizational display,
With checkboxes checked and data aligned,
The filters unfold, what results you'll find! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title accurately describes the main change: adding a new filter (formIds) to the advanced filters section of the Kanban board. The title is specific, concise, and clearly reflects the primary objective of the changeset.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch 331-feature-novo-filtro-para-solicitações

---

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments

src/app/(authenticated)/forms/kanban/_components/kanban-filters.tsx (2)

186-201: Formulário filter section is clean and conditionally rendered.

Conditionally rendering only when the user owns forms (formsData.length > 0) is a good UX choice. One minor nit: the formsData ?? [] fallback on line 194 is redundant since the outer guard on line 187 already ensures formsData is truthy.

Nitpick: remove redundant nullish coalescing

- options={(formsData ?? []).map((f) => ({ label: f.title ?? f.id, value: f.id }))}+ options={formsData.map((f) => ({ label: f.title ?? f.id, value: f.id }))}

---

46-56: Debounce effect has a stale closure risk with filters in the dependency array.

The filters object reference changes on every filter update (since state is spread with { ...filters, ... }), which resets the debounce timer on any filter change — not just the number input. This means changing e.g. a tag filter while typing a number will restart the 500ms timer. This is pre-existing behavior, but worth noting for a future improvement: consider extracting the number debounce into a separate hook or using only localNumber + a stable callback ref.

src/app/(authenticated)/forms/kanban/page.tsx (1)

169-172: Empty-state message correctly considers the new formIds filter.

The condition now accounts for filters.formIds.length > 0 to distinguish between "no results matching filters" and "no responses yet." Note that filters.hasResponse and filters.endDate and filters.priority are not checked here, but this is pre-existing behavior outside the scope of this PR.

For future consistency, consider consolidating the "has any active filter" check to reuse the hasActiveFilters logic from KanbanFiltersState (or the KanbanFilters component) rather than duplicating partial checks inline. This would prevent the two from drifting apart.

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[rbxyz]

Summary by CodeRabbit

Release Notes

• New Features

  • Added form-based filtering to Kanban board—filter tasks by specific forms
  • Collapsible advanced filters section for improved UI organization

• Improvements

  • Enhanced loading state with improved visual feedback in Kanban view

• Chores

  • Version bumped to 1.7.5

[vercel]

Deployment failed with the following error:

You don't have permission to create a Preview Deployment for this Vercel project: elo.

View Documentation: https://vercel.com/docs/accounts/team-members-and-roles

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR adds form-level filtering to the Kanban view with a collapsible advanced filters UI. It introduces form selection as a new filter dimension, implements the backend query procedures for fetching forms and filtering responses, enhances the loading UI, and updates the filter state to include formIds. Version bumped to 1.7.5.

Changes

Cohort / File(s)	Summary
Version package.json	Bumped version from 1.7.0 to 1.7.5.
Kanban UI & Filters src/app/(authenticated)/forms/kanban/_components/kanban-filters.tsx, src/app/(authenticated)/forms/kanban/page.tsx	Introduced collapsible UI for advanced filters with chevron toggle icons. Added formIds filter dimension with MultiSelect UI labeled "Formulário". Integrated forms data fetching via api.form.listForKanbanFilter.useQuery(). Updated loading and empty states with KanbanFilters controls and replaced Loader2 with KanbanSkeleton. Extended filter state initialization and clear logic to handle formIds.
Backend Filtering & Endpoints src/server/api/routers/form-response.ts, src/server/api/routers/forms.ts	Added optional formIds: string[] input to form-response list procedures to enable filtering by specific forms. Implemented where clause logic to apply form ID filter when provided. Added new listForKanbanFilter protected procedure to forms router returning form { id, title } for current user (as creator or owner), ordered by title.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Possibly related PRs

• feat: enhance form response filtering and loading states #209: Both PRs modify the same Kanban filters and form-response routing to extend filtering capabilities with formIds-based filtering logic.
• 31 adicionar filtros formularios #32: Both PRs add and integrate the KanbanSkeleton component into the Kanban view UI.

Poem

🐰 A form to filter, a collapsible way,
Where Kanban boards gleam in organizational display,
With checkboxes checked and data aligned,
The filters unfold, what results you'll find! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title accurately describes the main change: adding a new filter (formIds) to the advanced filters section of the Kanban board. The title is specific, concise, and clearly reflects the primary objective of the changeset.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch 331-feature-novo-filtro-para-solicitações

---

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments

src/app/(authenticated)/forms/kanban/_components/kanban-filters.tsx (2)

186-201: Formulário filter section is clean and conditionally rendered.

Conditionally rendering only when the user owns forms (formsData.length > 0) is a good UX choice. One minor nit: the formsData ?? [] fallback on line 194 is redundant since the outer guard on line 187 already ensures formsData is truthy.

Nitpick: remove redundant nullish coalescing

- options={(formsData ?? []).map((f) => ({ label: f.title ?? f.id, value: f.id }))}+ options={formsData.map((f) => ({ label: f.title ?? f.id, value: f.id }))}

---

46-56: Debounce effect has a stale closure risk with filters in the dependency array.

The filters object reference changes on every filter update (since state is spread with { ...filters, ... }), which resets the debounce timer on any filter change — not just the number input. This means changing e.g. a tag filter while typing a number will restart the 500ms timer. This is pre-existing behavior, but worth noting for a future improvement: consider extracting the number debounce into a separate hook or using only localNumber + a stable callback ref.

src/app/(authenticated)/forms/kanban/page.tsx (1)

169-172: Empty-state message correctly considers the new formIds filter.

The condition now accounts for filters.formIds.length > 0 to distinguish between "no results matching filters" and "no responses yet." Note that filters.hasResponse and filters.endDate and filters.priority are not checked here, but this is pre-existing behavior outside the scope of this PR.

For future consistency, consider consolidating the "has any active filter" check to reuse the hasActiveFilters logic from KanbanFiltersState (or the KanbanFilters component) rather than duplicating partial checks inline. This would prevent the two from drifting apart.

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[rbxyz]

Summary by CodeRabbit

Release Notes

• New Features

  • Added form-based filtering to Kanban board—filter tasks by specific forms
  • Collapsible advanced filters section for improved UI organization

• Improvements

  • Enhanced loading state with improved visual feedback in Kanban view

• Chores

  • Version bumped to 1.7.5

[vercel]

Deployment failed with the following error:

You don't have permission to create a Preview Deployment for this Vercel project: elo.

View Documentation: https://vercel.com/docs/accounts/team-members-and-roles

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR adds form-level filtering to the Kanban view with a collapsible advanced filters UI. It introduces form selection as a new filter dimension, implements the backend query procedures for fetching forms and filtering responses, enhances the loading UI, and updates the filter state to include formIds. Version bumped to 1.7.5.

Changes

Cohort / File(s)	Summary
Version package.json	Bumped version from 1.7.0 to 1.7.5.
Kanban UI & Filters src/app/(authenticated)/forms/kanban/_components/kanban-filters.tsx, src/app/(authenticated)/forms/kanban/page.tsx	Introduced collapsible UI for advanced filters with chevron toggle icons. Added formIds filter dimension with MultiSelect UI labeled "Formulário". Integrated forms data fetching via api.form.listForKanbanFilter.useQuery(). Updated loading and empty states with KanbanFilters controls and replaced Loader2 with KanbanSkeleton. Extended filter state initialization and clear logic to handle formIds.
Backend Filtering & Endpoints src/server/api/routers/form-response.ts, src/server/api/routers/forms.ts	Added optional formIds: string[] input to form-response list procedures to enable filtering by specific forms. Implemented where clause logic to apply form ID filter when provided. Added new listForKanbanFilter protected procedure to forms router returning form { id, title } for current user (as creator or owner), ordered by title.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Possibly related PRs

• feat: enhance form response filtering and loading states #209: Both PRs modify the same Kanban filters and form-response routing to extend filtering capabilities with formIds-based filtering logic.
• 31 adicionar filtros formularios #32: Both PRs add and integrate the KanbanSkeleton component into the Kanban view UI.

Poem

🐰 A form to filter, a collapsible way,
Where Kanban boards gleam in organizational display,
With checkboxes checked and data aligned,
The filters unfold, what results you'll find! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title accurately describes the main change: adding a new filter (formIds) to the advanced filters section of the Kanban board. The title is specific, concise, and clearly reflects the primary objective of the changeset.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch 331-feature-novo-filtro-para-solicitações

---

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments

src/app/(authenticated)/forms/kanban/_components/kanban-filters.tsx (2)

186-201: Formulário filter section is clean and conditionally rendered.

Conditionally rendering only when the user owns forms (formsData.length > 0) is a good UX choice. One minor nit: the formsData ?? [] fallback on line 194 is redundant since the outer guard on line 187 already ensures formsData is truthy.

Nitpick: remove redundant nullish coalescing

- options={(formsData ?? []).map((f) => ({ label: f.title ?? f.id, value: f.id }))}+ options={formsData.map((f) => ({ label: f.title ?? f.id, value: f.id }))}

---

46-56: Debounce effect has a stale closure risk with filters in the dependency array.

The filters object reference changes on every filter update (since state is spread with { ...filters, ... }), which resets the debounce timer on any filter change — not just the number input. This means changing e.g. a tag filter while typing a number will restart the 500ms timer. This is pre-existing behavior, but worth noting for a future improvement: consider extracting the number debounce into a separate hook or using only localNumber + a stable callback ref.

src/app/(authenticated)/forms/kanban/page.tsx (1)

169-172: Empty-state message correctly considers the new formIds filter.

The condition now accounts for filters.formIds.length > 0 to distinguish between "no results matching filters" and "no responses yet." Note that filters.hasResponse and filters.endDate and filters.priority are not checked here, but this is pre-existing behavior outside the scope of this PR.

For future consistency, consider consolidating the "has any active filter" check to reuse the hasActiveFilters logic from KanbanFiltersState (or the KanbanFilters component) rather than duplicating partial checks inline. This would prevent the two from drifting apart.

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}