342 lojinha pré cadastro - #344
Merged
Hidden character warning
The head ref may contain hidden characters: "342-lojinha---pr\u00e9-cadastro"
Merged
Conversation
…y and email notifications for order details
Deployment failed with the following error: View Documentation: https://vercel.com/docs/accounts/team-members-and-roles |
Contributor
📝 WalkthroughWalkthroughThis PR adds support for displaying and propagating Lojinha pre-registration customer data (name, CPF, address, phone, etc.) throughout the order management system. Changes include documentation updates clarifying LGPD data handling, UI enhancements to display pre-registration details in the order modal, email notification template expansions, and backend router modifications to expose and pass lojinha fields to notification flows. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~50 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (3)
src/components/ui/complete-profile-modal.tsx (1)
33-35: Pre-existing issue: Duplicate entry insetoresarray.Lines 33-34 contain a duplicate entry for "COMERCIAL" with the same value and label. This appears to be a pre-existing issue not introduced by this PR, but worth noting for future cleanup.
♻️ Proposed fix to remove duplicate
const setores = [ { value: "ADMINISTRATIVO", label: "Administrativo" }, { value: "COMERCIAL", label: "Comercial" }, - { value: "COMERCIAL", label: "Comercial" }, { value: "FINANCEIRO", label: "Financeiro" },🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/components/ui/complete-profile-modal.tsx` around lines 33 - 35, The setores array in src/components/ui/complete-profile-modal.tsx contains a duplicated entry ({ value: "COMERCIAL", label: "Comercial" }) — remove the redundant object so each sector appears only once; locate the setores array definition in complete-profile-modal.tsx and delete the duplicate element (keep a single "COMERCIAL" entry) ensuring array order and any downstream references to setores remain unchanged.src/server/api/routers/product-order.ts (1)
270-286: Consider extracting the dadosClienteLojinha construction to a helper function.The same pattern for building
dadosClienteLojinhais repeated for single orders (lines 270-273) and multiple orders (lines 546-549). Extracting this to a helper function would reduce duplication and improve maintainability.♻️ Proposed helper function
// At the top of the file or in a shared utilityfunctionbuildLojinhaClientData(user: {lojinha_full_name?: string|nulllojinha_cpf?: string|nulllojinha_address?: string|nulllojinha_neighborhood?: string|nulllojinha_cep?: string|nulllojinha_rg?: string|nulllojinha_email?: string|nulllojinha_phone?: string|null}|undefined|null): LojinhaClientData|null{if(!user)returnnullconstfields=[user.lojinha_full_name,user.lojinha_cpf,user.lojinha_address,user.lojinha_neighborhood,user.lojinha_cep,user.lojinha_rg,user.lojinha_email,user.lojinha_phone,]if(!fields.some(Boolean))returnnullreturn{lojinha_full_name: user.lojinha_full_name,lojinha_cpf: user.lojinha_cpf,lojinha_address: user.lojinha_address,lojinha_neighborhood: user.lojinha_neighborhood,lojinha_cep: user.lojinha_cep,lojinha_rg: user.lojinha_rg,lojinha_email: user.lojinha_email,lojinha_phone: user.lojinha_phone,}}// Usage:constdadosClienteLojinha=buildLojinhaClientData(order.user)🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/server/api/routers/product-order.ts` around lines 270 - 286, Extract the repeated construction of dadosClienteLojinha into a helper function (e.g. buildLojinhaClientData) that accepts order.user (or a nullable user object) and returns the LojinhaClientData object or null; replace the inline array+some(Boolean) check and object literal in both single-order and multi-order branches with a call to buildLojinhaClientData(order.user), and update usages passed to mockEmailNotificacaoPedidoProduto (and any other callers) to use the helper to remove duplication and centralize the null/field-check logic.src/components/admin/products/order-details-modal.tsx (1)
301-310: Consider extracting the lojinha user type to avoid inline type assertions.The inline type assertion is repeated here and at line 277. Once Prisma types are regenerated to include the new
lojinha_*fields in the user select, consider removing these assertions. Alternatively, define a local type or extend theProductOrderWithRelationstype to include these fields explicitly.♻️ Example type extraction
// At the top of the file, after the existing type definitionstypeLojinhaUserFields={lojinha_full_name?: string|nulllojinha_cpf?: string|nulllojinha_address?: string|nulllojinha_neighborhood?: string|nulllojinha_cep?: string|nulllojinha_rg?: string|nulllojinha_email?: string|nulllojinha_phone?: string|null}// Then use it in the componentconstu=order.userastypeoforder.user&LojinhaUserFields🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/components/admin/products/order-details-modal.tsx` around lines 301 - 310, The inline type assertion for order.user is duplicated and should be extracted into a reusable type to avoid repetition and prepare for Prisma type regeneration: create a local type alias (e.g., LojinhaUserFields) that declares lojinha_full_name, lojinha_cpf, lojinha_address, lojinha_neighborhood, lojinha_cep, lojinha_rg, lojinha_email, lojinha_phone as optional string|null and then replace the inline assertion in the component by combining the existing user type with that alias (for example using an intersection with typeof order.user or by extending ProductOrderWithRelations' user type) so both occurrences (the one at order.user and the earlier one around line 277) reference the single LojinhaUserFields type.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@src/components/admin/products/order-details-modal.tsx`:
- Around line 301-310: The inline type assertion for order.user is duplicated
and should be extracted into a reusable type to avoid repetition and prepare for
Prisma type regeneration: create a local type alias (e.g., LojinhaUserFields)
that declares lojinha_full_name, lojinha_cpf, lojinha_address,
lojinha_neighborhood, lojinha_cep, lojinha_rg, lojinha_email, lojinha_phone as
optional string|null and then replace the inline assertion in the component by
combining the existing user type with that alias (for example using an
intersection with typeof order.user or by extending ProductOrderWithRelations'
user type) so both occurrences (the one at order.user and the earlier one around
line 277) reference the single LojinhaUserFields type.
In `@src/components/ui/complete-profile-modal.tsx`:
- Around line 33-35: The setores array in
src/components/ui/complete-profile-modal.tsx contains a duplicated entry ({
value: "COMERCIAL", label: "Comercial" }) — remove the redundant object so each
sector appears only once; locate the setores array definition in
complete-profile-modal.tsx and delete the duplicate element (keep a single
"COMERCIAL" entry) ensuring array order and any downstream references to setores
remain unchanged.
In `@src/server/api/routers/product-order.ts`:
- Around line 270-286: Extract the repeated construction of dadosClienteLojinha
into a helper function (e.g. buildLojinhaClientData) that accepts order.user (or
a nullable user object) and returns the LojinhaClientData object or null;
replace the inline array+some(Boolean) check and object literal in both
single-order and multi-order branches with a call to
buildLojinhaClientData(order.user), and update usages passed to
mockEmailNotificacaoPedidoProduto (and any other callers) to use the helper to
remove duplication and centralize the null/field-check logic.
ℹ️ Review info
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
docs/05-Modulos/lgpd.mddocs/05-Modulos/shop.mdsrc/components/admin/products/order-details-modal.tsxsrc/components/ui/complete-profile-modal.tsxsrc/lib/mail/html-mock.tssrc/server/api/routers/product-order.ts
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Documentation