refactor: update action URLs in notification components and service t… - #47

Merged
rbxyz merged 1 commit into
mainfrom
34-adicionar-caixa-de-sugestões
Aug 26, 2025

Hidden character warning

The head ref may contain hidden characters: "34-adicionar-caixa-de-sugest\u00f5es"
Merged

refactor: update action URLs in notification components and service t…#47
rbxyz merged 1 commit into
mainfrom
34-adicionar-caixa-de-sugestões

Conversation

@rbxyz

@rbxyzrbxyz commented Aug 26, 2025

Copy link
Copy Markdown
Collaborator

…o point to /my-suggestions

Summary by CodeRabbit

  • Bug Fixes
    • Hide the action button in notifications and popups when the link points to admin pages, preventing inaccessible actions from appearing.
    • Update notification action links for suggestion and classification updates to direct users to /my-suggestions instead of admin routes, ensuring consistent, user-accessible navigation.
    • Preserves existing behaviors (mark as read, delete, and non-admin navigation) while improving clarity and reducing misdirected clicks.

@vercel

vercelBot commented Aug 26, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentPreviewCommentsUpdated (UTC)
eloReadyReadyPreviewCommentAug 26, 2025 7:26pm

@rbxyz
rbxyz merged commit 077fc91 into mainAug 26, 2025
3 of 4 checks passed
@coderabbitai

coderabbitaiBot commented Aug 26, 2025

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

Walkthrough

Action buttons for notifications are now suppressed for admin URLs. Multiple notification builders and API routes changed their actionUrl to /my-suggestions. UI components updated their render conditions so action buttons appear only when actionUrl exists and does not include "/admin/". No exported/public signatures changed.

Changes

Cohort / File(s)Summary of changes
UI: Notification action button condition
src/components/notifications/notification-item.tsx, src/components/notifications/notification-popup.tsx
Tightened render condition: show External Link/action button only when actionUrl exists and does not contain /admin/; other behaviors unchanged.
Notification payload URLs (service)
src/lib/notification-service.ts
Updated six builders to set actionUrl from /admin/suggestions?suggestion=\${suggestionId} to /my-suggestions; other fields unchanged.
Notification payload URLs (API router)
src/server/api/routers/suggestions.ts
For status/classification notifications, set actionUrl to /my-suggestions instead of admin query URL; triggers and other fields unchanged.

Sequence Diagram(s)

sequenceDiagram
autonumber
participant U as User
participant S as NotificationService
participant R as API Router (suggestions)
participant UI as Notification UI (Item/Popup)
participant Nav as Router/Navigation
U->>R: Perform suggestion action (status/classification update)
R->>S: Build notification payload (actionUrl=/my-suggestions)
S-->>R: Notification payload
R-->>UI: Push notification to client
UI->>UI: Render notification
alt actionUrl exists AND not containing "/admin/"
UI-->>U: Show action/External Link button
U->>UI: Click action
UI->>Nav: Navigate to actionUrl (/my-suggestions)
Nav-->>U: Destination shown
else actionUrl missing or contains "/admin/"
UI-->>U: No action button rendered
end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I thump my feet with gentle cheer,
A link hops left, now clearer here—
No admin burrows in this run,
To “my-suggestions” goes the fun.
Buttons bloom where they belong,
Notifications sing along.
Hippity-hop, the UX strong! 🥕✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between f29b336 and 95be691.

📒 Files selected for processing (4)
  • src/components/notifications/notification-item.tsx (1 hunks)
  • src/components/notifications/notification-popup.tsx (1 hunks)
  • src/lib/notification-service.ts (6 hunks)
  • src/server/api/routers/suggestions.ts (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 34-adicionar-caixa-de-sugestões

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@rbxyz
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

refactor: update action URLs in notification components and service t… - #47

Merged
rbxyz merged 1 commit into
mainfrom
34-adicionar-caixa-de-sugestões
Aug 26, 2025

Hidden character warning

The head ref may contain hidden characters: "34-adicionar-caixa-de-sugest\u00f5es"
Merged

refactor: update action URLs in notification components and service t…#47
rbxyz merged 1 commit into
mainfrom
34-adicionar-caixa-de-sugestões

Conversation

@rbxyz

@rbxyzrbxyz commented Aug 26, 2025

Copy link
Copy Markdown
Collaborator

…o point to /my-suggestions

Summary by CodeRabbit

  • Bug Fixes
    • Hide the action button in notifications and popups when the link points to admin pages, preventing inaccessible actions from appearing.
    • Update notification action links for suggestion and classification updates to direct users to /my-suggestions instead of admin routes, ensuring consistent, user-accessible navigation.
    • Preserves existing behaviors (mark as read, delete, and non-admin navigation) while improving clarity and reducing misdirected clicks.

@vercel

vercelBot commented Aug 26, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentPreviewCommentsUpdated (UTC)
eloReadyReadyPreviewCommentAug 26, 2025 7:26pm

@rbxyz
rbxyz merged commit 077fc91 into mainAug 26, 2025
3 of 4 checks passed
@coderabbitai

coderabbitaiBot commented Aug 26, 2025

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

Walkthrough

Action buttons for notifications are now suppressed for admin URLs. Multiple notification builders and API routes changed their actionUrl to /my-suggestions. UI components updated their render conditions so action buttons appear only when actionUrl exists and does not include "/admin/". No exported/public signatures changed.

Changes

Cohort / File(s)Summary of changes
UI: Notification action button condition
src/components/notifications/notification-item.tsx, src/components/notifications/notification-popup.tsx
Tightened render condition: show External Link/action button only when actionUrl exists and does not contain /admin/; other behaviors unchanged.
Notification payload URLs (service)
src/lib/notification-service.ts
Updated six builders to set actionUrl from /admin/suggestions?suggestion=\${suggestionId} to /my-suggestions; other fields unchanged.
Notification payload URLs (API router)
src/server/api/routers/suggestions.ts
For status/classification notifications, set actionUrl to /my-suggestions instead of admin query URL; triggers and other fields unchanged.

Sequence Diagram(s)

sequenceDiagram
autonumber
participant U as User
participant S as NotificationService
participant R as API Router (suggestions)
participant UI as Notification UI (Item/Popup)
participant Nav as Router/Navigation
U->>R: Perform suggestion action (status/classification update)
R->>S: Build notification payload (actionUrl=/my-suggestions)
S-->>R: Notification payload
R-->>UI: Push notification to client
UI->>UI: Render notification
alt actionUrl exists AND not containing "/admin/"
UI-->>U: Show action/External Link button
U->>UI: Click action
UI->>Nav: Navigate to actionUrl (/my-suggestions)
Nav-->>U: Destination shown
else actionUrl missing or contains "/admin/"
UI-->>U: No action button rendered
end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I thump my feet with gentle cheer,
A link hops left, now clearer here—
No admin burrows in this run,
To “my-suggestions” goes the fun.
Buttons bloom where they belong,
Notifications sing along.
Hippity-hop, the UX strong! 🥕✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between f29b336 and 95be691.

📒 Files selected for processing (4)
  • src/components/notifications/notification-item.tsx (1 hunks)
  • src/components/notifications/notification-popup.tsx (1 hunks)
  • src/lib/notification-service.ts (6 hunks)
  • src/server/api/routers/suggestions.ts (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 34-adicionar-caixa-de-sugestões

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@rbxyz
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

refactor: update action URLs in notification components and service t… - #47

Merged
rbxyz merged 1 commit into
mainfrom
34-adicionar-caixa-de-sugestões
Aug 26, 2025

Hidden character warning

The head ref may contain hidden characters: "34-adicionar-caixa-de-sugest\u00f5es"
Merged

refactor: update action URLs in notification components and service t…#47
rbxyz merged 1 commit into
mainfrom
34-adicionar-caixa-de-sugestões

Conversation

@rbxyz

@rbxyzrbxyz commented Aug 26, 2025

Copy link
Copy Markdown
Collaborator

…o point to /my-suggestions

Summary by CodeRabbit

  • Bug Fixes
    • Hide the action button in notifications and popups when the link points to admin pages, preventing inaccessible actions from appearing.
    • Update notification action links for suggestion and classification updates to direct users to /my-suggestions instead of admin routes, ensuring consistent, user-accessible navigation.
    • Preserves existing behaviors (mark as read, delete, and non-admin navigation) while improving clarity and reducing misdirected clicks.

@vercel

vercelBot commented Aug 26, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentPreviewCommentsUpdated (UTC)
eloReadyReadyPreviewCommentAug 26, 2025 7:26pm

@rbxyz
rbxyz merged commit 077fc91 into mainAug 26, 2025
3 of 4 checks passed
@coderabbitai

coderabbitaiBot commented Aug 26, 2025

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

Walkthrough

Action buttons for notifications are now suppressed for admin URLs. Multiple notification builders and API routes changed their actionUrl to /my-suggestions. UI components updated their render conditions so action buttons appear only when actionUrl exists and does not include "/admin/". No exported/public signatures changed.

Changes

Cohort / File(s)Summary of changes
UI: Notification action button condition
src/components/notifications/notification-item.tsx, src/components/notifications/notification-popup.tsx
Tightened render condition: show External Link/action button only when actionUrl exists and does not contain /admin/; other behaviors unchanged.
Notification payload URLs (service)
src/lib/notification-service.ts
Updated six builders to set actionUrl from /admin/suggestions?suggestion=\${suggestionId} to /my-suggestions; other fields unchanged.
Notification payload URLs (API router)
src/server/api/routers/suggestions.ts
For status/classification notifications, set actionUrl to /my-suggestions instead of admin query URL; triggers and other fields unchanged.

Sequence Diagram(s)

sequenceDiagram
autonumber
participant U as User
participant S as NotificationService
participant R as API Router (suggestions)
participant UI as Notification UI (Item/Popup)
participant Nav as Router/Navigation
U->>R: Perform suggestion action (status/classification update)
R->>S: Build notification payload (actionUrl=/my-suggestions)
S-->>R: Notification payload
R-->>UI: Push notification to client
UI->>UI: Render notification
alt actionUrl exists AND not containing "/admin/"
UI-->>U: Show action/External Link button
U->>UI: Click action
UI->>Nav: Navigate to actionUrl (/my-suggestions)
Nav-->>U: Destination shown
else actionUrl missing or contains "/admin/"
UI-->>U: No action button rendered
end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I thump my feet with gentle cheer,
A link hops left, now clearer here—
No admin burrows in this run,
To “my-suggestions” goes the fun.
Buttons bloom where they belong,
Notifications sing along.
Hippity-hop, the UX strong! 🥕✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between f29b336 and 95be691.

📒 Files selected for processing (4)
  • src/components/notifications/notification-item.tsx (1 hunks)
  • src/components/notifications/notification-popup.tsx (1 hunks)
  • src/lib/notification-service.ts (6 hunks)
  • src/server/api/routers/suggestions.ts (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 34-adicionar-caixa-de-sugestões

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@rbxyz
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

refactor: update action URLs in notification components and service t… - #47

Merged
rbxyz merged 1 commit into
mainfrom
34-adicionar-caixa-de-sugestões
Aug 26, 2025

Hidden character warning

The head ref may contain hidden characters: "34-adicionar-caixa-de-sugest\u00f5es"
Merged

refactor: update action URLs in notification components and service t…#47
rbxyz merged 1 commit into
mainfrom
34-adicionar-caixa-de-sugestões

Conversation

@rbxyz

@rbxyzrbxyz commented Aug 26, 2025

Copy link
Copy Markdown
Collaborator

…o point to /my-suggestions

Summary by CodeRabbit

  • Bug Fixes
    • Hide the action button in notifications and popups when the link points to admin pages, preventing inaccessible actions from appearing.
    • Update notification action links for suggestion and classification updates to direct users to /my-suggestions instead of admin routes, ensuring consistent, user-accessible navigation.
    • Preserves existing behaviors (mark as read, delete, and non-admin navigation) while improving clarity and reducing misdirected clicks.

@vercel

vercelBot commented Aug 26, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentPreviewCommentsUpdated (UTC)
eloReadyReadyPreviewCommentAug 26, 2025 7:26pm

@rbxyz
rbxyz merged commit 077fc91 into mainAug 26, 2025
3 of 4 checks passed
@coderabbitai

coderabbitaiBot commented Aug 26, 2025

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

Walkthrough

Action buttons for notifications are now suppressed for admin URLs. Multiple notification builders and API routes changed their actionUrl to /my-suggestions. UI components updated their render conditions so action buttons appear only when actionUrl exists and does not include "/admin/". No exported/public signatures changed.

Changes

Cohort / File(s)Summary of changes
UI: Notification action button condition
src/components/notifications/notification-item.tsx, src/components/notifications/notification-popup.tsx
Tightened render condition: show External Link/action button only when actionUrl exists and does not contain /admin/; other behaviors unchanged.
Notification payload URLs (service)
src/lib/notification-service.ts
Updated six builders to set actionUrl from /admin/suggestions?suggestion=\${suggestionId} to /my-suggestions; other fields unchanged.
Notification payload URLs (API router)
src/server/api/routers/suggestions.ts
For status/classification notifications, set actionUrl to /my-suggestions instead of admin query URL; triggers and other fields unchanged.

Sequence Diagram(s)

sequenceDiagram
autonumber
participant U as User
participant S as NotificationService
participant R as API Router (suggestions)
participant UI as Notification UI (Item/Popup)
participant Nav as Router/Navigation
U->>R: Perform suggestion action (status/classification update)
R->>S: Build notification payload (actionUrl=/my-suggestions)
S-->>R: Notification payload
R-->>UI: Push notification to client
UI->>UI: Render notification
alt actionUrl exists AND not containing "/admin/"
UI-->>U: Show action/External Link button
U->>UI: Click action
UI->>Nav: Navigate to actionUrl (/my-suggestions)
Nav-->>U: Destination shown
else actionUrl missing or contains "/admin/"
UI-->>U: No action button rendered
end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I thump my feet with gentle cheer,
A link hops left, now clearer here—
No admin burrows in this run,
To “my-suggestions” goes the fun.
Buttons bloom where they belong,
Notifications sing along.
Hippity-hop, the UX strong! 🥕✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between f29b336 and 95be691.

📒 Files selected for processing (4)
  • src/components/notifications/notification-item.tsx (1 hunks)
  • src/components/notifications/notification-popup.tsx (1 hunks)
  • src/lib/notification-service.ts (6 hunks)
  • src/server/api/routers/suggestions.ts (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 34-adicionar-caixa-de-sugestões

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@rbxyz
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

refactor: update action URLs in notification components and service t… - #47

Merged
rbxyz merged 1 commit into
mainfrom
34-adicionar-caixa-de-sugestões
Aug 26, 2025

Hidden character warning

The head ref may contain hidden characters: "34-adicionar-caixa-de-sugest\u00f5es"
Merged

refactor: update action URLs in notification components and service t…#47
rbxyz merged 1 commit into
mainfrom
34-adicionar-caixa-de-sugestões

Conversation

@rbxyz

@rbxyzrbxyz commented Aug 26, 2025

Copy link
Copy Markdown
Collaborator

…o point to /my-suggestions

Summary by CodeRabbit

  • Bug Fixes
    • Hide the action button in notifications and popups when the link points to admin pages, preventing inaccessible actions from appearing.
    • Update notification action links for suggestion and classification updates to direct users to /my-suggestions instead of admin routes, ensuring consistent, user-accessible navigation.
    • Preserves existing behaviors (mark as read, delete, and non-admin navigation) while improving clarity and reducing misdirected clicks.

@vercel

vercelBot commented Aug 26, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentPreviewCommentsUpdated (UTC)
eloReadyReadyPreviewCommentAug 26, 2025 7:26pm

@rbxyz
rbxyz merged commit 077fc91 into mainAug 26, 2025
3 of 4 checks passed
@coderabbitai

coderabbitaiBot commented Aug 26, 2025

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

Walkthrough

Action buttons for notifications are now suppressed for admin URLs. Multiple notification builders and API routes changed their actionUrl to /my-suggestions. UI components updated their render conditions so action buttons appear only when actionUrl exists and does not include "/admin/". No exported/public signatures changed.

Changes

Cohort / File(s)Summary of changes
UI: Notification action button condition
src/components/notifications/notification-item.tsx, src/components/notifications/notification-popup.tsx
Tightened render condition: show External Link/action button only when actionUrl exists and does not contain /admin/; other behaviors unchanged.
Notification payload URLs (service)
src/lib/notification-service.ts
Updated six builders to set actionUrl from /admin/suggestions?suggestion=\${suggestionId} to /my-suggestions; other fields unchanged.
Notification payload URLs (API router)
src/server/api/routers/suggestions.ts
For status/classification notifications, set actionUrl to /my-suggestions instead of admin query URL; triggers and other fields unchanged.

Sequence Diagram(s)

sequenceDiagram
autonumber
participant U as User
participant S as NotificationService
participant R as API Router (suggestions)
participant UI as Notification UI (Item/Popup)
participant Nav as Router/Navigation
U->>R: Perform suggestion action (status/classification update)
R->>S: Build notification payload (actionUrl=/my-suggestions)
S-->>R: Notification payload
R-->>UI: Push notification to client
UI->>UI: Render notification
alt actionUrl exists AND not containing "/admin/"
UI-->>U: Show action/External Link button
U->>UI: Click action
UI->>Nav: Navigate to actionUrl (/my-suggestions)
Nav-->>U: Destination shown
else actionUrl missing or contains "/admin/"
UI-->>U: No action button rendered
end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I thump my feet with gentle cheer,
A link hops left, now clearer here—
No admin burrows in this run,
To “my-suggestions” goes the fun.
Buttons bloom where they belong,
Notifications sing along.
Hippity-hop, the UX strong! 🥕✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between f29b336 and 95be691.

📒 Files selected for processing (4)
  • src/components/notifications/notification-item.tsx (1 hunks)
  • src/components/notifications/notification-popup.tsx (1 hunks)
  • src/lib/notification-service.ts (6 hunks)
  • src/server/api/routers/suggestions.ts (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 34-adicionar-caixa-de-sugestões

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@rbxyz
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

refactor: update action URLs in notification components and service t… - #47

Merged
rbxyz merged 1 commit into
mainfrom
34-adicionar-caixa-de-sugestões
Aug 26, 2025

Hidden character warning

The head ref may contain hidden characters: "34-adicionar-caixa-de-sugest\u00f5es"
Merged

refactor: update action URLs in notification components and service t…#47
rbxyz merged 1 commit into
mainfrom
34-adicionar-caixa-de-sugestões

Conversation

@rbxyz

@rbxyzrbxyz commented Aug 26, 2025

Copy link
Copy Markdown
Collaborator

…o point to /my-suggestions

Summary by CodeRabbit

  • Bug Fixes
    • Hide the action button in notifications and popups when the link points to admin pages, preventing inaccessible actions from appearing.
    • Update notification action links for suggestion and classification updates to direct users to /my-suggestions instead of admin routes, ensuring consistent, user-accessible navigation.
    • Preserves existing behaviors (mark as read, delete, and non-admin navigation) while improving clarity and reducing misdirected clicks.

@vercel

vercelBot commented Aug 26, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentPreviewCommentsUpdated (UTC)
eloReadyReadyPreviewCommentAug 26, 2025 7:26pm

@rbxyz
rbxyz merged commit 077fc91 into mainAug 26, 2025
3 of 4 checks passed
@coderabbitai

coderabbitaiBot commented Aug 26, 2025

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

Walkthrough

Action buttons for notifications are now suppressed for admin URLs. Multiple notification builders and API routes changed their actionUrl to /my-suggestions. UI components updated their render conditions so action buttons appear only when actionUrl exists and does not include "/admin/". No exported/public signatures changed.

Changes

Cohort / File(s)Summary of changes
UI: Notification action button condition
src/components/notifications/notification-item.tsx, src/components/notifications/notification-popup.tsx
Tightened render condition: show External Link/action button only when actionUrl exists and does not contain /admin/; other behaviors unchanged.
Notification payload URLs (service)
src/lib/notification-service.ts
Updated six builders to set actionUrl from /admin/suggestions?suggestion=\${suggestionId} to /my-suggestions; other fields unchanged.
Notification payload URLs (API router)
src/server/api/routers/suggestions.ts
For status/classification notifications, set actionUrl to /my-suggestions instead of admin query URL; triggers and other fields unchanged.

Sequence Diagram(s)

sequenceDiagram
autonumber
participant U as User
participant S as NotificationService
participant R as API Router (suggestions)
participant UI as Notification UI (Item/Popup)
participant Nav as Router/Navigation
U->>R: Perform suggestion action (status/classification update)
R->>S: Build notification payload (actionUrl=/my-suggestions)
S-->>R: Notification payload
R-->>UI: Push notification to client
UI->>UI: Render notification
alt actionUrl exists AND not containing "/admin/"
UI-->>U: Show action/External Link button
U->>UI: Click action
UI->>Nav: Navigate to actionUrl (/my-suggestions)
Nav-->>U: Destination shown
else actionUrl missing or contains "/admin/"
UI-->>U: No action button rendered
end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I thump my feet with gentle cheer,
A link hops left, now clearer here—
No admin burrows in this run,
To “my-suggestions” goes the fun.
Buttons bloom where they belong,
Notifications sing along.
Hippity-hop, the UX strong! 🥕✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between f29b336 and 95be691.

📒 Files selected for processing (4)
  • src/components/notifications/notification-item.tsx (1 hunks)
  • src/components/notifications/notification-popup.tsx (1 hunks)
  • src/lib/notification-service.ts (6 hunks)
  • src/server/api/routers/suggestions.ts (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 34-adicionar-caixa-de-sugestões

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@rbxyz
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

refactor: update action URLs in notification components and service t… - #47

Merged
rbxyz merged 1 commit into
mainfrom
34-adicionar-caixa-de-sugestões
Aug 26, 2025

Hidden character warning

The head ref may contain hidden characters: "34-adicionar-caixa-de-sugest\u00f5es"
Merged

refactor: update action URLs in notification components and service t…#47
rbxyz merged 1 commit into
mainfrom
34-adicionar-caixa-de-sugestões

Conversation

@rbxyz

@rbxyzrbxyz commented Aug 26, 2025

Copy link
Copy Markdown
Collaborator

…o point to /my-suggestions

Summary by CodeRabbit

  • Bug Fixes
    • Hide the action button in notifications and popups when the link points to admin pages, preventing inaccessible actions from appearing.
    • Update notification action links for suggestion and classification updates to direct users to /my-suggestions instead of admin routes, ensuring consistent, user-accessible navigation.
    • Preserves existing behaviors (mark as read, delete, and non-admin navigation) while improving clarity and reducing misdirected clicks.

@vercel

vercelBot commented Aug 26, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentPreviewCommentsUpdated (UTC)
eloReadyReadyPreviewCommentAug 26, 2025 7:26pm

@rbxyz
rbxyz merged commit 077fc91 into mainAug 26, 2025
3 of 4 checks passed
@coderabbitai

coderabbitaiBot commented Aug 26, 2025

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

Walkthrough

Action buttons for notifications are now suppressed for admin URLs. Multiple notification builders and API routes changed their actionUrl to /my-suggestions. UI components updated their render conditions so action buttons appear only when actionUrl exists and does not include "/admin/". No exported/public signatures changed.

Changes

Cohort / File(s)Summary of changes
UI: Notification action button condition
src/components/notifications/notification-item.tsx, src/components/notifications/notification-popup.tsx
Tightened render condition: show External Link/action button only when actionUrl exists and does not contain /admin/; other behaviors unchanged.
Notification payload URLs (service)
src/lib/notification-service.ts
Updated six builders to set actionUrl from /admin/suggestions?suggestion=\${suggestionId} to /my-suggestions; other fields unchanged.
Notification payload URLs (API router)
src/server/api/routers/suggestions.ts
For status/classification notifications, set actionUrl to /my-suggestions instead of admin query URL; triggers and other fields unchanged.

Sequence Diagram(s)

sequenceDiagram
autonumber
participant U as User
participant S as NotificationService
participant R as API Router (suggestions)
participant UI as Notification UI (Item/Popup)
participant Nav as Router/Navigation
U->>R: Perform suggestion action (status/classification update)
R->>S: Build notification payload (actionUrl=/my-suggestions)
S-->>R: Notification payload
R-->>UI: Push notification to client
UI->>UI: Render notification
alt actionUrl exists AND not containing "/admin/"
UI-->>U: Show action/External Link button
U->>UI: Click action
UI->>Nav: Navigate to actionUrl (/my-suggestions)
Nav-->>U: Destination shown
else actionUrl missing or contains "/admin/"
UI-->>U: No action button rendered
end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I thump my feet with gentle cheer,
A link hops left, now clearer here—
No admin burrows in this run,
To “my-suggestions” goes the fun.
Buttons bloom where they belong,
Notifications sing along.
Hippity-hop, the UX strong! 🥕✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between f29b336 and 95be691.

📒 Files selected for processing (4)
  • src/components/notifications/notification-item.tsx (1 hunks)
  • src/components/notifications/notification-popup.tsx (1 hunks)
  • src/lib/notification-service.ts (6 hunks)
  • src/server/api/routers/suggestions.ts (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 34-adicionar-caixa-de-sugestões

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@rbxyz
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

refactor: update action URLs in notification components and service t… - #47

Merged
rbxyz merged 1 commit into
mainfrom
34-adicionar-caixa-de-sugestões
Aug 26, 2025

Hidden character warning

The head ref may contain hidden characters: "34-adicionar-caixa-de-sugest\u00f5es"
Merged

refactor: update action URLs in notification components and service t…#47
rbxyz merged 1 commit into
mainfrom
34-adicionar-caixa-de-sugestões

Conversation

@rbxyz

@rbxyzrbxyz commented Aug 26, 2025

Copy link
Copy Markdown
Collaborator

…o point to /my-suggestions

Summary by CodeRabbit

  • Bug Fixes
    • Hide the action button in notifications and popups when the link points to admin pages, preventing inaccessible actions from appearing.
    • Update notification action links for suggestion and classification updates to direct users to /my-suggestions instead of admin routes, ensuring consistent, user-accessible navigation.
    • Preserves existing behaviors (mark as read, delete, and non-admin navigation) while improving clarity and reducing misdirected clicks.

@vercel

vercelBot commented Aug 26, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentPreviewCommentsUpdated (UTC)
eloReadyReadyPreviewCommentAug 26, 2025 7:26pm

@rbxyz
rbxyz merged commit 077fc91 into mainAug 26, 2025
3 of 4 checks passed
@coderabbitai

coderabbitaiBot commented Aug 26, 2025

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

Walkthrough

Action buttons for notifications are now suppressed for admin URLs. Multiple notification builders and API routes changed their actionUrl to /my-suggestions. UI components updated their render conditions so action buttons appear only when actionUrl exists and does not include "/admin/". No exported/public signatures changed.

Changes

Cohort / File(s)Summary of changes
UI: Notification action button condition
src/components/notifications/notification-item.tsx, src/components/notifications/notification-popup.tsx
Tightened render condition: show External Link/action button only when actionUrl exists and does not contain /admin/; other behaviors unchanged.
Notification payload URLs (service)
src/lib/notification-service.ts
Updated six builders to set actionUrl from /admin/suggestions?suggestion=\${suggestionId} to /my-suggestions; other fields unchanged.
Notification payload URLs (API router)
src/server/api/routers/suggestions.ts
For status/classification notifications, set actionUrl to /my-suggestions instead of admin query URL; triggers and other fields unchanged.

Sequence Diagram(s)

sequenceDiagram
autonumber
participant U as User
participant S as NotificationService
participant R as API Router (suggestions)
participant UI as Notification UI (Item/Popup)
participant Nav as Router/Navigation
U->>R: Perform suggestion action (status/classification update)
R->>S: Build notification payload (actionUrl=/my-suggestions)
S-->>R: Notification payload
R-->>UI: Push notification to client
UI->>UI: Render notification
alt actionUrl exists AND not containing "/admin/"
UI-->>U: Show action/External Link button
U->>UI: Click action
UI->>Nav: Navigate to actionUrl (/my-suggestions)
Nav-->>U: Destination shown
else actionUrl missing or contains "/admin/"
UI-->>U: No action button rendered
end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I thump my feet with gentle cheer,
A link hops left, now clearer here—
No admin burrows in this run,
To “my-suggestions” goes the fun.
Buttons bloom where they belong,
Notifications sing along.
Hippity-hop, the UX strong! 🥕✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between f29b336 and 95be691.

📒 Files selected for processing (4)
  • src/components/notifications/notification-item.tsx (1 hunks)
  • src/components/notifications/notification-popup.tsx (1 hunks)
  • src/lib/notification-service.ts (6 hunks)
  • src/server/api/routers/suggestions.ts (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 34-adicionar-caixa-de-sugestões

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@rbxyz