Skip to content

Improve the read me and fix the import issues - #7

Merged
Moasib-Arif merged 5 commits into
mainfrom
1-Installable
Jan 4, 2024
Merged

Improve the read me and fix the import issues#7
Moasib-Arif merged 5 commits into
mainfrom
1-Installable

Conversation

@Moasib-Arif

Copy link
Copy Markdown
Contributor

Changes:

  • Added the Instructions how to install the repo from Github to local Machine (ReadMe File)
  • Issues with imports (http and Config )fixed / All the import work

@mikeAdamssmikeAdamss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few tweaks to make around dependencies and installation but nothing major, give me a shout if I've explained badly.

RE test failure, its just failing as its looking to produce code coverage but no tests exist to run so it cant find any results.

for now just add a /tests/test_nothing.py file containing:


# TODO - remove as soon as we add our first test.
def test_nothing():
"""
Empty test to stop failures for 0 coverage
"""
...

And that'll move us to a green tick.

Comment threadPipfile Outdated
Comment threadPipfile.lock Outdated
Comment threaddpytools/__init__.py Outdated
Comment threadREADME.md
Signed-off-by: Moasib-Arif <moasib_arif@yahoo.com>
@Moasib-Arif
Moasib-Arif merged commit e34f671 into mainJan 4, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Moasib-Arif@mikeAdamss