Uh oh!
There was an error while loading. Please reload this page.
Draft PR - #9
Conversation
mikeAdamss
left a comment
There was a problem hiding this comment.
this is a very complex thing that's not really doing what I though it was doing (nobodies fault, the api logger was a rush merge and it shows a bit).
I've tried to leave comments, but broadly:
- make a script that imports DpLogger and does a bunch of logging statements, there's similar in one of my comments.
- make sure to
configure_logger()in the init. I'm not sure that should be a separate function tbh but we'll figure that out at the real PR. - at that point when you run your script it'll be punting json logs into your terminal
- from there it's just twiddling them into the right structures to meet the DP logging standards.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
mikeAdamss
commented
Jan 15, 2024
@SarahJohnsonONS - had a binge on this and pushed code to it. Logger should be working and pumping out json lines now and I've sketched how we can test it with a few comments. can you have a look and get back to me if it doesn't make sense? It's much simpler like this. |
Uh oh!
There was an error while loading. Please reload this page.
Some of the required functionality implemented, but I'm a bit stuck on certain parts. See the comments in logger.py (prefaced with #4 for ease of searching).