Uh oh!
There was an error while loading. Please reload this page.
Add remote configs listener to the C API + Linux build compatibility fixes - #48
Open
Gogoshika-ga wants to merge 10 commits into
Open
Add remote configs listener to the C API + Linux build compatibility fixes#48Gogoshika-ga wants to merge 10 commits into
Gogoshika-ga wants to merge 10 commits into
Conversation
Replace the CMake>=3.25-only LINUX variable with UNIX AND NOT APPLE, and the non-existent CLANG variable with a CMAKE_CXX_COMPILER_ID match so the clang libc++ flags are actually applied. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Statically link curl/openssl/zlib into the DLL so the Unity plugin is a single self-contained GameAnalytics.dll. The -static-md variant keeps the dynamic CRT (/MD) to match shared builds. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Discard an unparseable cached config (e.g. legacy C# base64 format) instead of logging it as an error; a fresh config is fetched on init and rewritten as JSON. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…igs-listener # Conflicts: # source/gameanalytics/GAState.cpp # source/gameanalytics/Platform/GALinux.cpp
LCOV of commit |
dorin-ga
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a remote configs callback to the C API so managed runtimes (Unity P/Invoke) can be notified when remote configs arrive, instead of polling
isRemoteConfigsReady(). Also mergesfix_linux_compatibility.Added
gameAnalytics_configureRemoteConfigsListener()with aGARemoteConfigsListenercallback. Single listener: re-registering replaces it,NULLunregisters. Register beforeinitialize()to not miss the first update.exported_symbols_apple.txt— restricts shared-library exports to_gameAnalytics_*on Apple platforms.Fixed
if(LINUX)→if(UNIX AND NOT APPLE)(LINUXrequires CMake 3.25+ and was silently false on older versions).CMAKE_CXX_COMPILER MATCHES "clang"→CMAKE_CXX_COMPILER_ID.getOSVersion()on Linux: signed/unsigned comparison warning and UB from passing a plainchartoisdigit.setup.pypicks thewindows-static-md/windows-staticvcpkg triplet to matchCMAKE_MSVC_RUNTIME_LIBRARY.Testing
Not built on Linux — the Linux-only changes are unverified beyond review.
🤖 Generated with Claude Code