Give the spec workstream leads owner parity - #62
Merged
Conversation
PR #59 fixed a response-envelope defect and shipped the test that proves the fix. @bar-capsule approved it and the merge stayed blocked, because CODEOWNERS gave the spec leads /specification/ and /docs/spec/ but not /tests/, /pyproject.toml, or /uv.lock. A spec lead could approve the schema change and not the test that holds it to its own contract. That splits a single reviewable change across two owner tiers, and it will recur on every spec PR that carries its own coverage. Any fix narrow enough to unblock only that case would leave the same seam somewhere else, so @afogel and @bar-capsule join all 21 restricted lines rather than a chosen subset. Both already hold maintain, so the entries take effect on merge. The /.github/ comment claimed these paths warrant admin review. Both new owners hold maintain, so the comment now describes what the list is for and points at GOVERNANCE.md for who decides membership. Signed-off-by: rocklambros <rock@rockcyber.com>
rocklambros
requested review from
GangGreenTemperTatum,
fewdisc,
mamicidal and
sclintonowasp
as code owners
September 9, 2026 20:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Adds
@afogeland@bar-capsuleto all 21 restricted CODEOWNERS lines, giving the Spec workstream leads owner parity with the project leads.PR #59 is the case that prompted this. It fixed a real defect in
response-envelope.jsonand shippedtests/test_response_envelope.pyto prove the fix.@bar-capsuleapproved it and the merge stayed blocked, because CODEOWNERS granted the spec leads/specification/and/docs/spec/but not/tests/,/pyproject.toml, or/uv.lock. A spec lead could approve the schema change and not the test that holds it to its own contract.That splits one reviewable change across two owner tiers, and it recurs on every spec PR that carries its own coverage, which should be all of them. A narrower grant covering only
/tests/and the packaging files would unblock that exact case and leave the same seam waiting somewhere else, so both handles join every restricted line instead of a chosen subset.Both already hold
maintainon the repository, so the entries take effect on merge rather than failing silently the way the header warns about.The
/.github/comment claimed those paths warrant admin review. Both new owners holdmaintain, so that comment no longer described the list it sat above. It now says what the narrow list is for and points atGOVERNANCE.mdfor who decides membership.Type of change
Worth a reviewer's attention
GOVERNANCE.md:35says a leadership change opens a PR touchingGOVERNANCE.md,project.owasp.yaml, and.github/CODEOWNERStogether. This PR touches only CODEOWNERS, on the reading that it is not a leadership change:@afogeland@bar-capsuleare already Spec workstream leads atGOVERNANCE.md:21, and this widens what they own rather than who they are.project.owasp.yamlcarries no role field and capsleadersat five, so nothing there changes either.The part that deserves a second opinion is the workstream table. It frames each workstream as owning a slice of the standard, and after this the Spec leads own every path in the repository. If that reads as a role change rather than a scope change,
GOVERNANCE.mdshould say so, and I would rather a reviewer make that call than assume it.Checklist
git commit -s(required by the DCO)uv run mkdocs build --strictpassesSecurity
This change has security relevance and is worth stating plainly rather than checking a box.
/.github/is a privilege-escalation surface, because CI runs with write access to the repository. This PR grants two more people the ability to approve changes to it, along with/LICENSE,/SECURITY.md,/LICENSING.md,/NOTICE, and/GOVERNANCE.md. The ruleset still requires an approving review and still blocks self-approval throughrequire_last_push_approval, so no single person can land a workflow change alone. The grant is deliberate and made by the project lead underGOVERNANCE.md:35.