perf: async file saving in web generation endpoint - #100
Open
saquibsaifee wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@eaglei15 this PR is ready to be reviewed. |
Refactored _save_task in generate_form to split synchronous JSON encoding into the threadpool, while lifting the file-writing actions out into the async event loop using aiofiles. - Added aiofiles dependency to pyproject.toml. - Added test_generate_uses_aiofiles_async unit test to cover async logic and mocks aiofiles. Signed-off-by: saquibsaifee <saquibsaifee2@gmail.com>
saquibsaifee
force-pushed
the
perf-async-file-io-9118509034411377622
branch
from
August 31, 2026 17:05
fe2c615 to
bab46e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 What: The
generate_formendpoint was previously performing synchronous disk I/O (with open(...)) inside of a ThreadPoolExecutor worker, which causes thread exhaustion and blocks thread workers under load. I've updated the endpoint to useaiofilesfor asynchronous, non-blocking disk I/O inside the event loop, while keeping only CPU-bound JSON string formatting in the threadpool.🎯 Why: To improve throughput and scalability of the web server. Thread pool resources shouldn't be held up by disk writing.
📊 Measured Improvement: In synthetic load testing (100 sequential write tasks representing high concurrent load in a web scenario), switching from ThreadPoolExecutor thread-blocking I/O to
aiofilesasync tasks dropped the duration from ~1.06s to ~0.42s (over a 2.5x speedup in freeing concurrency execution flow).