Uh oh!
There was an error while loading. Please reload this page.
chore: change default version from 1.0.0 to 0.0.1 - #94
Merged
Conversation
Update all model defaults, service fallbacks, app.manifest assembly version, and the test app ClientVersion default to 0.0.1. Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the tool’s default version baselines to start at 0.0.1 (and 0.0.1.0 for the Windows manifest) instead of 1.0.0, aligning “initial release” semantics across model defaults, service fallbacks, and the test client.
Changes:
- Updated default version values in multiple config/view models to
0.0.1. - Updated service fallback versions used when generating manifests / running simulations to
0.0.1. - Updated Windows
app.manifestassembly identity version to0.0.1.0and the test client default version to0.0.1.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test_app/Client/Program.cs | Changes test client CLI default ClientVersion to 0.0.1. |
| src/Services/SimulationService.cs | Updates simulation-generated manifest fallback UpgradeClientVersion to 0.0.1. |
| src/Services/ManifestGeneratorService.cs | Updates manifest generation fallbacks to 0.0.1 (also contains a blank-input override bug noted in comments). |
| src/Models/SimulateConfigModel.cs | Changes default CurrentVersion to 0.0.1. |
| src/Models/PatchConfigModel.cs | Changes default package Version to 0.0.1. |
| src/Models/OSSConfigModel.cs | Changes default Version to 0.0.1. |
| src/Models/ManifestModel.cs | Changes default manifest versions (ClientVersion, UpgradeClientVersion) to 0.0.1. |
| src/Models/ExtensionConfigModel.cs | Changes default extension Version to 0.0.1. |
| src/Models/ConfigGeneratorModel.cs | Changes default config generator versions (ClientVersion, UpgradeClientVersion) to 0.0.1. |
| src/app.manifest | Updates assemblyIdentity version to 0.0.1.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ? userInput.MainAppName | ||
| : client.AssemblyName, | ||
| ClientVersion = userInput?.ClientVersion ?? "1.0.0", | ||
| ClientVersion = userInput?.ClientVersion ?? "0.0.1", |
| ? userInput.UpdateAppName | ||
| : upgrade?.AssemblyName ?? "Update.exe", | ||
| UpgradeClientVersion = userInput?.UpgradeClientVersion ?? "1.0.0", | ||
| UpgradeClientVersion = userInput?.UpgradeClientVersion ?? "0.0.1", |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#93
All default version values across the codebase now start at
0.0.1instead of1.0.0.Summary of changes
ExtensionConfigModel,ConfigGeneratorModel,ManifestModel,OSSConfigModel,PatchConfigModel,SimulateConfigModel)ManifestGeneratorService,SimulationService)app.manifestversion →0.0.1.0test_app/Client/Program.csClientVersiondefaultNote
Placeholder/example strings in JSON locale files and
.axamlviews remain unchanged — they serve as semver format examples for user input.