add support for concrete floating_point union - #112
Open
yuanzhuo-dev wants to merge 1 commit into
Open
Conversation
Member
|
Thanks for the PR! Can you also add some unit test cases to validate the execution of f32/f64/f80 numbers? |
Author
|
Sure! I’ll work on adding some unit test cases to verify those floating-point operations. I think I’ll first make sure the existing f80 operations are working correctly, and then test the new f32/f64 operations. |
Member
|
That sounds good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Prof.Guannan,
I modify struct FloatV, and add a union type called "Float_val" to replace the original implementation of "long double".
If there are any issues during your code review, please feel free to contact me.