Uh oh!
There was an error while loading. Please reload this page.
[Backport 6.1] Handle matrix via reference for grid input - #3838
Merged
Conversation
* Handle matrix vai reference for grid input Testing is done via testapi_matrix_360_ref.c Seems to work but raises an issue related to memory freeing. Since the matrix data is only pointed to by the grid, I set the grid alloc_mode to external. However, that also means that the x and y arrays that are created when creating the grid is left unfreed at the end. We could just ignore this rare memory leak or do something about it. One way is to add info to the struct HIDDEN so that we free those arrays even those the matrix is left untouched. * Add PS orig * Update gmt_api.c * Update gmt_grdio.c * Fix output ij * Handle a switch from reference to duplicate * make sure we set min/max when needed and not reset it * use lessons learned from MATRIX/DUPLICATE to GRID/DUPLICATE Lots of errors there as well and probalby never accessed. * Use duplcate for 360 adn ref for 360_ref Also fix the region assignment * Apply same logic for finding min/max as for duplicate * handle non-projection in grdimage when a referenced global grid
PaulWessel
self-requested a review
August 4, 2020 19:36
PaulWessel
approved these changes
Aug 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 4c18338 from #3829